Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved ansible-galaxy cli STDOUT messages for collections #70040

Merged
merged 1 commit into from Jun 29, 2020
Merged

Improved ansible-galaxy cli STDOUT messages for collections #70040

merged 1 commit into from Jun 29, 2020

Conversation

saito-hideki
Copy link
Member

@saito-hideki saito-hideki commented Jun 12, 2020 •
edited

SUMMARY

Improved ansible-galaxy cli STDOUT messages for collections.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • ansible-galaxy (collections)
ADDITIONAL INFORMATION
Before:
$ ansible-galaxy collection install netapp.azure                     
Starting galaxy collection install process
Process install dependency map
Starting collection install process
Installing 'netapp.azure:20.6.0' to '/home/foo/work/testing/ansible/collections/ansible_collections/netapp/azure'

$ ansible-galaxy collection download netapp.azure
Starting collection download process to '/home/foo/work/testing/ansible/collections'
Downloading collection 'netapp.azure' to '/home/foo/work/testing/ansible/collections/netapp-azure-20.6.0.tar.gz'
Writing requirements.yml file of downloaded collections to '/home/foo/work/testing/ansible/collections/requirements.yml'
After:
$ ansible-galaxy collection install netapp.azure                
Starting galaxy collection install process
Process install dependency map
Starting collection install process
Installing 'netapp.azure:20.6.0' to '/home/foo/work/testing/ansible/collections/ansible_collections/netapp/azure'
Downloading https://galaxy.ansible.com/download/netapp-azure-20.6.0.tar.gz to /home/foo/.ansible/tmp/ansible-local-41431qt1o1ehp/tmp5ttxfihl
netapp.azure (20.6.0) was installed successfully

$ ansible-galaxy collection download netapp.azure
Starting collection download process to '/home/foo/work/testing/ansible/collections'
Downloading collection 'netapp.azure' to '/home/foo/work/testing/ansible/collections/netapp-azure-20.6.0.tar.gz'
Downloading https://galaxy.ansible.com/download/netapp-azure-20.6.0.tar.gz to /home/foo/.ansible/tmp/ansible-local-83636fd5ug3me/tmpey9gvwgv
Writing requirements.yml file of downloaded collections to '/home/foo/work/testing/ansible/collections/requirements.yml'
netapp.azure (20.6.0) was downloaded successfully

@saito-hideki saito-hideki changed the title Improved ansible-galaxy cli STDOUT messages for collections [WIP] Improved ansible-galaxy cli STDOUT messages for collections Jun 12, 2020
@saito-hideki saito-hideki reopened this Jun 12, 2020
@saito-hideki saito-hideki force-pushed the issue/70010 branch 2 times, most recently from c21b0ec to 970e1f6 Compare June 12, 2020 16:07
@saito-hideki saito-hideki reopened this Jun 12, 2020
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 12, 2020
@saito-hideki saito-hideki reopened this Jun 12, 2020
@saito-hideki saito-hideki reopened this Jun 12, 2020
@saito-hideki saito-hideki reopened this Jun 12, 2020
@saito-hideki
Copy link
Member Author

saito-hideki commented Jun 13, 2020 •
edited

/rebuild_failed

3 similar comments
@saito-hideki
Copy link
Member Author

/rebuild_failed

@saito-hideki
Copy link
Member Author

saito-hideki commented Jun 13, 2020 •
edited

/rebuild_failed

@saito-hideki
Copy link
Member Author

/rebuild_failed

@saito-hideki saito-hideki changed the title [WIP] Improved ansible-galaxy cli STDOUT messages for collections Improved ansible-galaxy cli STDOUT messages for collections Jun 14, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jun 14, 2020
@saito-hideki saito-hideki changed the title Improved ansible-galaxy cli STDOUT messages for collections [WIP] Improved ansible-galaxy cli STDOUT messages for collections Jun 15, 2020
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jun 15, 2020
@Akasurde Akasurde mentioned this pull request Jun 16, 2020
Closed
s-hertel
s-hertel approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@s-hertel s-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. You might want to specify the collection subcommand in the changelog since this doesn't affect ansible-galaxy role.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 16, 2020
@saito-hideki
Improve ansible-galaxy STDOUT messages for collections
badeb0e 
- Fix issue ansible#70010
- Add installation successful message
- This feature targets "collection" sub-command and does not affect "role" sub-command

Signed-off-by: Hideki Saito <saito@fgrep.org>
@saito-hideki
Copy link
Member Author

/rebuild_failed

@saito-hideki saito-hideki changed the title [WIP] Improved ansible-galaxy cli STDOUT messages for collections Improved ansible-galaxy cli STDOUT messages for collections Jun 17, 2020
@ansibot ansibot removed the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Jun 17, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 25, 2020
@Akasurde
Copy link
Member

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. shipit This PR is ready to be merged by Core labels Jun 29, 2020
@samdoran samdoran merged commit 2d59e54 into ansible:devel Jun 29, 2020
@ansible ansible locked and limited conversation to collaborators Jul 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@s-hertel s-hertel s-hertel approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 feature This issue/PR relates to a feature request. has_issue needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@saito-hideki @Akasurde @s-hertel @samdoran @ansibot