add the role version number to the ansible-galaxy error/warning message

[jainnikhil30]

SUMMARY

cc @sudhirmohanraj, This is taken from your original PR #52853 which was closed.

Fixes: #52111

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ansible-galaxy

ADDITIONAL INFORMATION

Before:

[niks@localhost]$ ansible-galaxy install -r requirements.yml 
- downloading role 'dummy', owned by 
[WARNING]: - dummy was NOT installed successfully: None (HTTP Code: 400, Message: Bad Request)
ERROR! - you can use --ignore-errors to skip failed roles and finish processing the list.

After this PR:

(venv) [niks@localhost ]$ ansible-galaxy install -r /home/niks/ansible_test/requirements.yml 
[WARNING]: You are running the development version of Ansible. You should only run Ansible from "devel" if you are modifying the Ansible engine, or trying out features under development. This is a rapidly changing source of code and can
become unstable at any point.
Starting galaxy role install process
- downloading role 'dummy', owned by 
[WARNING]: - dummy 1.1 was NOT installed successfully: None (HTTP Code: 400, Message: Bad Request)
ERROR! - you can use --ignore-errors to skip failed roles and finish processing the list.

[samdoran]

Looking at the original issue more closely, I don't think this fixes it. Simply displaying the version or * in the error message will just continue to mask the problem.

The real issue is the git checkout failure because a non-existing version was requested. That is what the error message should state.

[Akasurde]

@samdoran Could you please take a look? Thanks.

[samdoran]

It still seems like this change is not helping to better identify the real underlying cause.

[jainnikhil30]

@samdoran

Thanks for your review. I will try and make that error more explicit in terms of version not being available remotely.

[Akasurde]

@jainnikhil30 Could you please address the @samdoran comment?

needs_info

[ansibot]

@jainnikhil30 This pullrequest is waiting for your response. Please respond or the pullrequest will be closed.

click here for bot help

[ansibot]

@jainnikhil30 You have not responded to information requests in this pullrequest so we will assume it no longer affects you. If you are still interested in this, please create a new pullrequest with the requested information.

click here for bot help