Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flatten handling of nulls/nones #70141

Merged
merged 7 commits into from Jul 1, 2020
Merged

fix flatten handling of nulls/nones #70141

merged 7 commits into from Jul 1, 2020

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jun 18, 2020 •
edited

fixed null break bug and added option to include

fixes #69012
fixes #69013 (adds clog, tests and options to orig fix)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

flatten

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 18, 2020
@ansibot ansibot added docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 19, 2020
Shrews
Shrews requested changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@Shrews Shrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the skip_nulls param to the recursive flatten() calls.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Jun 23, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 23, 2020
@bcoca @Shrews
Update lib/ansible/plugins/filter/core.py
f4740ce 
Co-authored-by: David Shrewsbury <Shrews@users.noreply.github.com>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 23, 2020
@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Jun 23, 2020
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jun 23, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jul 1, 2020
@Shrews Shrews merged commit 7a15a3a into ansible:devel Jul 1, 2020
@Shrews Shrews mentioned this pull request Jul 2, 2020
Merged
@ansible ansible locked and limited conversation to collaborators Jul 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Shrews Shrews Shrews approved these changes

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flatten field yields unexpected results when it hits None
5 participants
@bcoca @Shrews @samdoran @ansibot @borisovano