Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hostname: hostnamectl check -> SystemdStrategy #70532

Merged
merged 3 commits into from
Jul 10, 2020
Merged

hostname: hostnamectl check -> SystemdStrategy #70532

merged 3 commits into from
Jul 10, 2020

Commits on Jul 9, 2020

  1. hostname: hostnamectl check -> SystemdStrategy 

    Change:
- Move hostnamectl check out of GenericStrategy because it was incorrect
  for everything except the SystemdStrategy which is where it belongs.
- Add some initial tests for the hostname module, though we are limited
  by the fact that we can't do much testing with it in containers.

Test Plan:
- new hostname integration tests

Signed-off-by: Rick Elrod <rick@elrod.me>
    @relrod
    relrod committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    8ea861d View commit details
    Browse the repository at this point in the history

  2. Update lib/ansible/modules/hostname.py 

    Co-authored-by: Sam Doran <sdoran@redhat.com>
    @relrod @samdoran
    relrod and samdoran committed Jul 9, 2020
    Configuration menu
    Copy the full SHA
    cf55ab5 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2020

  1. feedback 

    Signed-off-by: Rick Elrod <rick@elrod.me>
    @relrod
    relrod committed Jul 10, 2020
    Configuration menu
    Copy the full SHA
    0ec5196 View commit details
    Browse the repository at this point in the history