Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a friendly error if you use the validate option but forget: %s #7072

Merged
merged 1 commit into from May 9, 2014
Merged

Show a friendly error if you use the validate option but forget: %s #7072

merged 1 commit into from May 9, 2014

Conversation

jjshoe
Copy link
Contributor

@jjshoe jjshoe commented Apr 19, 2014

before:

fatal: [192.168.33.10] => failed to parse: Traceback (most recent call last):
  File "/home/vagrant/.ansible/tmp/ansible-tmp-1397870557.51-203219450016801/copy", line 1326, in <module>
    main()
  File "/home/vagrant/.ansible/tmp/ansible-tmp-1397870557.51-203219450016801/copy", line 210, in main
    (rc,out,err) = module.run_command(validate % src)
TypeError: not all arguments converted during string formatting

after:

failed: [192.168.33.10] => {"failed": true, "item": "", "md5sum": "cb9915cece456389db174d2e69311f57"}
msg: validate must contain %s: /bin/true

@bcoca
Copy link
Member

bcoca commented Apr 27, 2014

github gremlins attack once in a while, I generally just delete and
recreate the branch when this happens.​

@jjshoe
Copy link
Contributor Author

jjshoe commented Apr 27, 2014

@bcoca cleaned up my fubar, good to go with this pr

@bcoca
Copy link
Member

bcoca commented Apr 27, 2014

great, but I don't have commit access, so you'll have to wait for someone
else ;-)

@jimi-c jimi-c merged commit a34478d into ansible:devel May 9, 2014
@jimi-c
Copy link
Member

jimi-c commented May 9, 2014

Merged, thanks!

@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants