Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.10] Sanitize URI module keys with no_log values (#70762) #70820

Merged
merged 1 commit into from Jul 23, 2020
Merged

[2.10] Sanitize URI module keys with no_log values (#70762) #70820

merged 1 commit into from Jul 23, 2020

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Jul 22, 2020

SUMMARY

Sanitize uri module response keys.

Fixes: #70455

(cherry picked from commit bf98f03)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

uri
module_utils

ADDITIONAL INFORMATION

@Shrews
Sanitize URI module keys with no_log values (ansible#70762)
f8413b4 
* Add sanitize_keys() to module_utils.

* More robust tests

* Revert 69653 change

* Allow list or dict

* fix pep8

* Sanitize lists within dict values

* words

* First pass at uri module

* Fix insane sanity tests

* fix integration tests

* Add changelog

* Remove unit test introduced in 69653

* Add ignore_keys param

* Sanitize all-the-things

* Ignore '_ansible*' keys

* cleanup

* Use module.no_log_values

* Avoid deep recursion issues by using deferred removal structure.

* Nit cleanups

* Add doc blurb

* spelling

* ci_complete

(cherry picked from commit bf98f03)
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 22, 2020
@nitzmahone nitzmahone merged commit 7cdba7c into ansible:stable-2.10 Jul 23, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Jul 24, 2020
@ansible ansible locked and limited conversation to collaborators Aug 20, 2020
@Shrews Shrews deleted the backport/2.10/70762 branch January 7, 2021 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. module This issue/PR relates to a module. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shrews @sivel @ansibot @nitzmahone