Fix ansible-test relative import analysis. #70973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @tremble |
ansibot
added
affects_2.11
bug
mattclay
removed
the
needs_triage
tremble
reviewed
Jul 30, 2020
| # This assumes that all files within the collection are executed by Ansible as part of the collection. | ||
| # While that will usually be true, there are exceptions which will result in this resolution being incorrect. | ||
| self.module = path_to_module(os.path.join(data_context().content.collection.directory, self.path)) | ||
|
|
||
| # noinspection PyPep8Naming | ||
| # pylint: disable=locally-disabled, invalid-name | ||
| def visit_Import(self, node): |
There was a problem hiding this comment.
Dumb question: should visit_Import be updated too?
There was a problem hiding this comment.
Only the from ... import statement supports relative imports, so there's nothing to do for the import statement.
tremble
approved these changes
Jul 30, 2020
This was referenced Jul 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fix ansible-test relative import analysis.
Replaces #70866
Resolves ansible-collections/amazon.aws#110
ISSUE TYPE
Bugfix Pull Request
COMPONENT NAME
ansible-test