Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow checksum file to be local file:// url #71205

Merged
merged 6 commits into from
Aug 17, 2020
Merged

Allow checksum file to be local file:// url #71205

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f82f9f6
Allow checksum file to be local file:// url
madeddie Aug 11, 2020
d43b160
Make checksum url parsing more explicit
madeddie Aug 13, 2020
1d826c5
Fix whitespace
madeddie Aug 13, 2020
681d3ca
Changelog fragment
madeddie Aug 13, 2020
77ea705
Added tests
madeddie Aug 13, 2020
e160814
Fix typo in test setup
Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ansible/modules/get_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -487,7 +487,7 @@ def main():
except ValueError:
module.fail_json(msg="The checksum parameter has to be in format <algorithm>:<checksum>", **result)

if checksum.startswith('http://') or checksum.startswith('https://') or checksum.startswith('ftp://'):
if checksum.startswith('http://') or checksum.startswith('https://') or checksum.startswith('ftp://') or checksum.startswith('file://'):
samdoran marked this conversation as resolved.
Show resolved Hide resolved
checksum_url = checksum
# download checksum file to checksum_tmpsrc
checksum_tmpsrc, checksum_info = url_get(module, checksum_url, dest, use_proxy, last_mod_time, force, timeout, headers, tmp_dest)
Expand Down