Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] [Experimental Thing] [Oh god what am I doing] Move HostVars instantiation to VariableManager #71512

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from
Draft

[WIP] [Experimental Thing] [Oh god what am I doing] Move HostVars instantiation to VariableManager #71512

wants to merge 1 commit into from
+9 −14

Conversation

relrod
Copy link
Member

@relrod relrod commented Aug 28, 2020

SUMMARY

Change:

  • TQM was only using this for its side effect. Let VariableManager do
    the work instead.

Test Plan:

  • CI

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

hostvars, TQM, varsmanager

@relrod
Move HostVars instantiation to VariableManager
ebb9662 
Change:
- TQM was only using this for its side effect. Let VariableManager do
  the work instead.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.11 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 28, 2020
@relrod relrod changed the title [WIP] Move HostVars instantiation to VariableManager [WIP] [Experimental Thing] [Oh god what am I doing] Move HostVars instantiation to VariableManager Aug 28, 2020
@Shrews Shrews removed the needs_triage Needs a first human triage before being processed. label Sep 3, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 11, 2020
@ansibot ansibot added pre_azp This PR was last tested before migration to Azure Pipelines. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 8, 2020
@ansibot ansibot removed the support:community This issue/PR relates to code supported by the Ansible community. label Mar 4, 2021
@mattclay
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the pre_azp This PR was last tested before migration to Azure Pipelines. label Jun 22, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jun 30, 2022
@webknjaz

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@webknjaz
Copy link
Member

The branch is too old for the CI to pick it up. Needs rebase.

@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Oct 10, 2023
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Oct 10, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@relrod @mattclay @webknjaz @Shrews @ansibot