Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Make sure that none is not accepted for required module options #72248

Closed
wants to merge 15 commits into from
Closed

[WIP] Make sure that none is not accepted for required module options #72248

wants to merge 15 commits into from

Commits on Feb 14, 2021

  1. Handle explicit None correctly for required* checks.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    3be8e8a View commit details
    Browse the repository at this point in the history

  2. Adjust apt_repository integration test.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    c5034b3 View commit details
    Browse the repository at this point in the history

  3. Adjust incidental tests.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    5d3357f View commit details
    Browse the repository at this point in the history

  4. Allow 'allow_none_value' in argspec validation.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    baabdb6 View commit details
    Browse the repository at this point in the history

  5. Add test for allow_none_value.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    b2ebc50 View commit details
    Browse the repository at this point in the history

  6. Add information to porting guide.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    40e397e View commit details
    Browse the repository at this point in the history

  7. Fix changelog fragment.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    bd82a83 View commit details
    Browse the repository at this point in the history

  8. Do not fail, but warn if none is specified for a required option.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    3feaaa3 View commit details
    Browse the repository at this point in the history

  9. Fix changelog fragment's section.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    4e0ac03 View commit details
    Browse the repository at this point in the history

  10. Turn changed required_by behavior into deprecation.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    1807ad6 View commit details
    Browse the repository at this point in the history

  11. Revert "Adjust incidental tests." 

    This reverts commit 155c9de.
    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    7396a41 View commit details
    Browse the repository at this point in the history

  12. Revert "Adjust apt_repository integration test." 

    This reverts commit 01ec1be.
    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    c99d6b2 View commit details
    Browse the repository at this point in the history

  13. Update porting guide entry.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    39661aa View commit details
    Browse the repository at this point in the history

  14. Adjust to changes in devel.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    5cc6bf1 View commit details
    Browse the repository at this point in the history

  15. Forgot to substitute name during rebase.

    @felixfontein
    felixfontein committed Feb 14, 2021
    Copy the full SHA
    113913b View commit details
    Browse the repository at this point in the history