systemd - use list-unit-files rather than list-units #72363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
list-unit-files will return all files on the system. list-units omits those that are disabled. Co-authored-by: Ken Dreyer <ktdreyer@ktdreyer.com>
samdoran
force-pushed
the
issue/71528-systemd-lies-more
branch
from
c7eafed
to
4cf9674
Compare
ansibot
added
affects_2.11
bug
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Oct 27, 2020
…nsible#72363) list-unit-files will return all files on the system. list-units omits those that are disabled. Co-authored-by: Ken Dreyer <ktdreyer@ktdreyer.com>. (cherry picked from commit d611588) Co-authored-by: Sam Doran <sdoran@redhat.com>
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Oct 27, 2020
…sible#72363) list-unit-files will return all files on the system. list-units omits those that are disabled. Co-authored-by: Ken Dreyer <ktdreyer@ktdreyer.com> (cherry picked from commit d611588)
samdoran
added a commit
to samdoran/ansible
that referenced
this pull request
Oct 27, 2020
…nsible#72363) list-unit-files will return all files on the system. list-units omits those that are disabled. Co-authored-by: Ken Dreyer <ktdreyer@ktdreyer.com> (cherry picked from commit d611588)
bcoca
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Follow up fix for #71528 per this feedback from @ktdreyer.
list-unitsonly displays units that are active, have pending jobs, or have failed. If a unit exists but is not enabled, it won't show up and thesystemdmodule will not properly manage it.ISSUE TYPE
COMPONENT NAME
lib/ansible/modules/systemd.py