Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.9] Fix missing ansible.builtin FQCNs in hardcoded action names #72458

Merged
merged 3 commits into from
Dec 7, 2020

Conversation

felixfontein
Copy link
Contributor

@felixfontein felixfontein commented Nov 3, 2020

SUMMARY

Backport of #71824 and #72471 to stable-2.9.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

core

…71824)

* Make sure hard-coded action names also check for FQCN.
* Use _add_internal_fqcn() to avoid hardcoded lists and typoes.

(cherry picked from commit da60525)

ci_complete
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. utilities Utilities category labels Nov 3, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 5, 2020
@felixfontein
Copy link
Contributor Author

/rebuild_failed

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Nov 5, 2020
@felixfontein
Copy link
Contributor Author

/rebuild_failed

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 6, 2020
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 14, 2020
@felixfontein felixfontein reopened this Dec 3, 2020
@ansibot ansibot added has_issue and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 3, 2020
@relrod relrod merged commit aa47109 into ansible:stable-2.9 Dec 7, 2020
@felixfontein felixfontein deleted the backport/2.9/71824 branch December 7, 2020 16:29
@felixfontein
Copy link
Contributor Author

@relrod thanks!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 7, 2020
@felixfontein
Copy link
Contributor Author

This backport was missing something to make ansible.builtin.command: /bin/ls work; see #72958.

@ansible ansible locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. utilities Utilities category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants