Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow key None to prevent errors with import test #73003

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Fix from #72497 (comment) as individual PR.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

test/integration/targets/ansible-test/ansible_collections/ns/col/plugins/filter/check_pylint.py

@ansibot ansibot added affects_2.11 community_review In order to be merged, this PR must follow the community review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. labels Dec 17, 2020
@felixfontein felixfontein changed the title Allow key None to prevent errors with import test [WIP] Allow key None to prevent errors with import test Dec 17, 2020
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. and removed community_review In order to be merged, this PR must follow the community review workflow. labels Dec 17, 2020
@felixfontein felixfontein changed the title [WIP] Allow key None to prevent errors with import test Allow key None to prevent errors with import test Dec 17, 2020
@felixfontein
Copy link
Contributor Author

Seems to fix the problem in #72497. The remaining errors are FreeBSD related.

@felixfontein
Copy link
Contributor Author

CC @mattclay

@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Dec 17, 2020
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Dec 17, 2020
@mattclay mattclay merged commit dbc2c99 into ansible:devel Dec 17, 2020
@felixfontein felixfontein deleted the fix-pylint branch December 17, 2020 17:19
@felixfontein
Copy link
Contributor Author

@mattclay thanks for suggesting this and thanks for merging!

mattclay pushed a commit to mattclay/ansible that referenced this pull request Dec 17, 2020
relrod pushed a commit that referenced this pull request Jan 11, 2021
* Rename pylint plugin and add tests. (#70225)
* Update ansible-test pylint Python support. (#72972)
* Add integration tests for sanity test failures.
(cherry picked from commit fa48678)

* Python 3.8 is now officially supported.
* Python 3.9 is now skipped with a warning.
(cherry picked from commit 37d09f2)

* Allow key None to prevent errors with import test.
(cherry picked from commit dbc2c99)

Backport of #73003

Co-authored-by: Felix Fontein <felix@fontein.de>
@ansible ansible locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 community_review In order to be merged, this PR must follow the community review workflow. support:community This issue/PR relates to code supported by the Ansible community.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants