Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/egg info #7306

Merged
merged 2 commits into from Dec 15, 2014
Merged

Feature/egg info #7306

merged 2 commits into from Dec 15, 2014

Conversation

abadger
Copy link
Contributor

@abadger abadger commented May 6, 2014

pkg_resources does its work by reading in metadata about a python package saved in egg-info files. Regular installs of ansible (python setup.py install) will create the egg-info but for hacking on ansible from a checkout we need to generate egg-info so that the pkg_resources calls in ansible-vault and ansible-playbook can get the information. hacking/env-setup is the way that we tell people to setup their dev environment so script creation of the egg-info there.

@abadger
Copy link
Contributor Author

abadger commented May 6, 2014

@jimi-c Here's the pull request that lets ansible-vault and ansible-playbook work from a checkout I promised you yesterday.

@jimi-c jimi-c added P3 labels May 6, 2014
@jimi-c
Copy link
Member

jimi-c commented May 6, 2014

@abadger thanks, we'll take a look at this as soon as possible.

@mpdehaan mpdehaan added P4 and removed P3 labels Jun 1, 2014
@mpdehaan
Copy link
Contributor

Hi @abadger sorry for the delay on this one (large queue as you're aware!), one of the ideas behind hacking/env-setup was that it should not modify your system, i.e. you should be able to do this (or python setup.py develop now, on devel) and then stop using the new version to go back to using your old ansible.

Would this cause trouble by over-writing a file from a previous install?

Thanks!

@abadger
Copy link
Contributor Author

abadger commented Aug 13, 2014

@mpdehaan If I understand your question, this should be okay. It modifies the egg-info files in the checkout directory, not any files on the system. So, for instance, you should be able to run "source ./hacking/env-setup" in the checkout in one terminal and use the the ansible from the checkout. In a separate terminal, using ansible will use the system installed ansible.

The files on the system (module, scripts, and egg-info) are modified if you do a python setup.py install as per normal.

@abadger
Copy link
Contributor Author

abadger commented Oct 9, 2014

Just a note -- also have to patch /sur/bin/ansible similarly so that ansible --vault-password works.

bcoca added a commit that referenced this pull request Dec 15, 2014
@bcoca bcoca merged commit 88443d6 into ansible:devel Dec 15, 2014
@ansibot ansibot added bug This issue/PR relates to a bug. and removed bugfix_pull_request labels Mar 5, 2018
@ansible ansible locked and limited conversation to collaborators Apr 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants