Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support venv in ansible-test virtualenv scripts #73163

Merged
merged 2 commits into from Jan 8, 2021
Merged

Support venv in ansible-test virtualenv scripts #73163

merged 2 commits into from Jan 8, 2021

Conversation

mattclay
Copy link
Member

@mattclay mattclay commented Jan 8, 2021

SUMMARY

Backport of #73000

The new behavior is opt-in, using the ANSIBLE_TEST_PREFER_VENV environment variable.

This change provides better compatibility when testing across multiple Ansible versions.

The macOS provisioning change is backwards compatible, since the macOS 10.15 image already includes virtualenv.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ansible-test

samdoran and others added 2 commits January 7, 2021 21:21
@samdoran @mattclay
ansible-test - prefer venv over virtualenv on Python 3 (ansible#73000)
a48b3d2 
Also pin virtualenv to 16.7.10 for older Mac OS X systems. This was the version being installed
anway with the previous constraint (<20).

On systems with Python 3, now prefer venv over virtualenv. Test to see if venv is functional since
some systems have a non-functional venv installation (such as Debian).

(cherry picked from commit 850a77f)
@mattclay
Make the new ansible-test venv behavior opt-in
3f311d1
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Jan 8, 2021
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jan 8, 2021
@mattclay mattclay mentioned this pull request Jan 8, 2021
Merged
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 8, 2021
@relrod relrod merged commit 4452d98 into ansible:stable-2.10 Jan 8, 2021
@mattclay mattclay deleted the venv-2.10 branch January 9, 2021 04:07
@ansible ansible locked and limited conversation to collaborators Feb 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mattclay @relrod @ansibot @samdoran