Make sure collection name is included in plugin deprecations from collections #73239
+19
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
botmeta
felixfontein
force-pushed
the
fix-plugin-deprecations-1
branch
from
3f622bc
to
6355511
Compare
|
A test for this is contained in #73240. |
ansibot
added
needs_revision
|
/rebuild_failed |
ansibot
added
core_review
felixfontein
commented
Jan 17, 2021
| @@ -799,7 +801,8 @@ def get_with_context(self, name, *args, **kwargs): | |||
|
|
|||
| if path not in self._module_cache: | |||
| self._module_cache[path] = self._load_module_source(name, path) | |||
| self._load_config_defs(name, self._module_cache[path], path) | |||
| self._load_config_defs( | |||
| name, self._module_cache[path], path, collection_name=plugin_load_context.plugin_resolved_collection) | |||
There was a problem hiding this comment.
@bcoca including the collection name in name isn't trivial, since sometimes name is not a short name, but something else; for example I saw ansible_collections.ansible.builtin.plugins.lookup.file when running the following playbook:
- hosts: localhost
tasks:
- debug:
msg: "{{ lookup('ansible.builtin.file', 'asdf') }}"
I guess that this shouldn't happen and should be fixed, but without that fixed I don't see how to combine name + collection name into one parameter without introducing a new syntax (that uses another separator).
ansibot
added
needs_revision
Shrews
removed
the
needs_triage
ansibot
added
the
stale_ci
ansibot
removed
the
support:community
felixfontein
force-pushed
the
fix-plugin-deprecations-1
branch
from
b61a863
to
f9f1876
Compare
ansibot
removed
the
stale_ci
ansibot
added
needs_revision
ansibot
added
the
stale_ci
ansibot
added
needs_rebase
|
@felixfontein Is this still something you're working on and would like to rebase? |
|
@mattclay if there is a chance that this will actually get reviewed and merged, I would like to rebase and update it. |
|
@felixfontein Is there benefit to merging this without also having #73240? |
|
OK, perhaps we're better off waiting until #73051 is resolved then. |
ansibot
removed
the
needs_revision
ansibot
added
needs_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Make sure collection name is included in plugin deprecations from collections.
(One part of #73058.)
ISSUE TYPE
COMPONENT NAME
lib/ansible/plugins/loader.py