undepr hash_merge #73328
Merged
undepr hash_merge #73328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
This comment has been minimized.
This comment has been minimized.
ansibot
added
needs_revision
samccann
reviewed
Jan 22, 2021
ansibot
added
core_review
This comment has been minimized.
This comment has been minimized.
ansibot
added
needs_revision
added updates from sloan's PR feedback from others Co-authored-by: Sloane Hertel <shertel@redhat.com> Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Sandra McCann <samccann@redhat.com>
bcoca
force-pushed
the
undepr_hash_behaviour
branch
from
2ac1678
to
8eff929
Compare
samccann
approved these changes
Jan 22, 2021
samccann
removed
the
needs_triage
|
Thanks! :) 👏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in core IRC meeting. We'd like to re-evaluate the deprecation when new options become available, but the warning stands. This is magical, and if you are relying on it you probably want to think about the readability of your stuff and try to do things more explicitly.
fixes #73089
ISSUE TYPE
COMPONENT NAME
config