Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no tty, no wrap #73834

Draft
wants to merge 7 commits into
base: devel
Choose a base branch
from
Draft

no tty, no wrap #73834

wants to merge 7 commits into from
+33 −24

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 9, 2021

fixes #71461
fixes #71462 (alternative)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

display

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 9, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Mar 10, 2021
@mattclay mattclay marked this pull request as draft March 11, 2021 19:49
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 11, 2021
@ansibot ansibot added the WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. label Mar 11, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 19, 2021
@bcoca
Copy link
Member Author

bcoca commented Nov 3, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bcoca
no tty, no wrap
204cc3d 
  fixes ansible#71461
  fixes ansible#71462 (alternative)
@ansibot ansibot removed ci_verified Changes made in this PR are causing tests to fail. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Nov 3, 2021
@bcoca
use toggle
209c455 
  most of our tests dump output w/o tty to check aginast expected
  formatted output, this will ensure backwards compat
@bcoca
only if, not if if
dbec61f
@bcoca
cenetralize wrapping
9ab9b40
@bcoca
reorganized wrapping
c3b83b6 
 made simple by having one condition
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 2, 2022
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Jun 15, 2022
@bcoca bcoca mentioned this pull request Aug 11, 2022
Open
@kristianheljas kristianheljas mentioned this pull request Feb 25, 2023
Closed
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. has_issue needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible should not wrap lines when tty is absent
4 participants
@bcoca @ansibot @mattclay @samdoran