Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure unit test paths for connection and inventory plugins are based on the context #73877

Merged
merged 3 commits into from
Mar 12, 2021
Merged

Ensure unit test paths for connection and inventory plugins are based on the context #73877

merged 3 commits into from
Mar 12, 2021

Conversation

tremble
Copy link
Contributor

@tremble tremble commented Mar 12, 2021

SUMMARY

Ansible puts tests into test/units/
Collections put tests into tests/unit/

use data_context to find the right location

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-test

ADDITIONAL INFORMATION

fixes #73876

@tremble
Ensure unit test paths for connection and inventory plugins are based…
4ee03dd 
… on the data_context

Ansible puts tests into test/units/
Collections put tests into tests/unit/

use data_context to find the right location
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 12, 2021
@mattclay mattclay self-requested a review March 12, 2021 17:07
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 12, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 12, 2021
@mattclay mattclay self-assigned this Mar 12, 2021
@mattclay mattclay added this to In progress in Testing Collections via automation Mar 12, 2021
mattclay
mattclay requested changes Mar 12, 2021
View reviewed changes
Copy link
Member

@mattclay mattclay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs a changelog fragment.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 12, 2021
@tremble tremble requested a review from mattclay March 12, 2021 19:38
@tremble @felixfontein
Update changelogs/fragments/73876-ansible_test-units.yml
2d0540c 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Mar 12, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 12, 2021
@mattclay mattclay merged commit ed18fca into ansible:devel Mar 12, 2021
Testing Collections automation moved this from In progress to Done Mar 12, 2021
tremble added a commit to tremble/ansible that referenced this pull request Mar 13, 2021
@tremble
Ensure unit test paths for connection and inventory plugins are based…
48055a1 
… on the context (ansible#73877)
tremble added a commit to tremble/ansible that referenced this pull request Mar 13, 2021
@tremble
Ensure unit test paths for connection and inventory plugins are based…
00390d8 
… on the context (ansible#73877)
This was referenced Mar 13, 2021
Merged
Merged
mattclay pushed a commit that referenced this pull request Mar 19, 2021
@tremble @mattclay
Ensure unit test paths for connection and inventory plugins are based…
7ef1a2f 
… on the context (#73877)
mattclay pushed a commit that referenced this pull request Mar 19, 2021
@tremble @mattclay
Ensure unit test paths for connection and inventory plugins are based…
84e61b3 
… on the context (#73877)
@ansible ansible locked and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@felixfontein felixfontein felixfontein approved these changes

Assignees

@mattclay mattclay

Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
Testing Collections
  
Done
Milestone
No milestone
4 participants
@tremble @mattclay @felixfontein @ansibot