Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrofit shippable scripts to work with AZP #73994

Merged
merged 1 commit into from Apr 28, 2021
Merged

Retrofit shippable scripts to work with AZP #73994

merged 1 commit into from Apr 28, 2021

Conversation

eqrx
Copy link
Contributor

@eqrx eqrx commented Mar 22, 2021 •
edited

SUMMARY

Scripts under hacking/shippable are still only compatible with shippable, even though we switched to AZP. This PR makes them the scripts work with AZP.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@eqrx eqrx requested a review from mattclay March 22, 2021 14:29
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 22, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 22, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 22, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 22, 2021
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Mar 23, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 24, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 25, 2021
mattclay
mattclay requested changes Mar 30, 2021
View reviewed changes
hacking/shippable/incidental.py Outdated Show resolved Hide resolved
hacking/shippable/download.py Outdated Show resolved Hide resolved
hacking/shippable/rebalance.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 30, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Mar 31, 2021
@eqrx eqrx requested a review from mattclay April 1, 2021 13:08
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 1, 2021
@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Apr 9, 2021
mattclay
mattclay requested changes Apr 23, 2021
View reviewed changes
hacking/shippable/download.py Outdated Show resolved Hide resolved
hacking/shippable/download.py Outdated Show resolved Hide resolved
hacking/shippable/download.py Outdated Show resolved Hide resolved
@ansibot ansibot removed stale_review Updates were made after the last review and the last review is more than 7 days old. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Apr 23, 2021
@eqrx @mattclay
Retrofit shippable scripts to work with AZP
cf39230 
Co-authored-by: Matt Clay <matt@mystile.com>
@eqrx eqrx requested a review from mattclay April 28, 2021 16:22
@mattclay mattclay merged commit 2621478 into ansible:devel Apr 28, 2021
@ansible ansible locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eqrx @ansibot @mattclay @mkrizek