Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: wait_for_connection returning unreachable when ignore_unreachable #74323

Closed
wants to merge 1 commit into from
Closed

wip: wait_for_connection returning unreachable when ignore_unreachable #74323

wants to merge 1 commit into from

Conversation

goshansp
Copy link

SUMMARY

Should fix #74300

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

wait_for_connection

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 16, 2021
@bcoca
Copy link
Member

bcoca commented Apr 16, 2021

This change is still backwards incompatible. Also, actions should not really change behavior unless you are passing specific options to it.

bcoca
bcoca requested changes Apr 16, 2021
View reviewed changes
Copy link
Member

@bcoca bcoca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also missing changelog and tests, but previous comment is main blocker.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 17, 2021
@goshansp goshansp changed the title wait_for_connection returning unreachable when ignore_unreachable wip: wait_for_connection returning unreachable when ignore_unreachable Apr 17, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 17, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 20, 2021
@goshansp
Copy link
Author

this PR becomes obselete as switching from wait_for_connection to ping seems to fix all my issues. further i think wait_for_connection is not behaving according documentation or as expected and it should be deprecated as from my understanding it seems to be replaceable using ping/unti/retries.

@goshansp goshansp closed this Apr 23, 2021
@ansible ansible locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca requested changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

wait_for_connection should not fail when ignore_unreachable=true
4 participants
@goshansp @bcoca @samdoran @ansibot