Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update argcomplete docs links on installation guide #74410

Merged
merged 1 commit into from Apr 27, 2021

Conversation

lidimayra
Copy link
Contributor

@lidimayra lidimayra commented Apr 24, 2021

SUMMARY

argcomplete docs link on installation docs is outdated.

Currently argcomplete docs are available at:
https://kislyuk.github.io/argcomplete/

ISSUE TYPE
  • Docs Pull Request

@ansibot
Copy link
Contributor

ansibot commented Apr 24, 2021

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/installation_guide/intro_installation.rst:6:0: warning: Duplicate explicit target name: "argcomplete documentation".

The test ansible-test sanity --test rstcheck [explain] failed with 1 error:

docs/docsite/rst/installation_guide/intro_installation.rst:6:0: Duplicate explicit target name: "argcomplete documentation".

click here for bot help

@ansibot ansibot added affects_2.12 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. docs_only All changes are to files within the docs/docsite/ directory needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 24, 2021
Link on installation docs is outdated.

Currently argcomplete docs are available at:
https://kislyuk.github.io/argcomplete/
@lidimayra lidimayra force-pushed the update-argcomplete-link-on-docs branch from 71cab5b to e3e328e Compare April 24, 2021 20:22
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 24, 2021
@Akasurde
Copy link
Member

@lidimayra Thanks for the contribution and for taking the time to read the documentation carefully.

@Akasurde Akasurde removed the needs_triage Needs a first human triage before being processed. label Apr 27, 2021
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acozine
Copy link
Contributor

acozine commented Apr 27, 2021

Thanks @lidimayra!

@acozine acozine merged commit f97787c into ansible:devel Apr 27, 2021
maximmasiutin pushed a commit to maximmasiutin/ansible that referenced this pull request Apr 28, 2021
acozine pushed a commit to acozine/ansible that referenced this pull request Apr 28, 2021
Link on installation docs is outdated. Switch to currently docs at: https://kislyuk.github.io/argcomplete/

(cherry picked from commit f97787c)
@acozine acozine mentioned this pull request Apr 28, 2021
acozine added a commit that referenced this pull request Apr 28, 2021
* Add description for COLLECTIONS_SCAN_SYS_PATH (#74351)

Fixes: #74275

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 567361b)

* lighten navigation background to make section labels easier to read for core docs (#74356)

* make section labels for /ansible-core/ docs easier to read, with black text and lighter gray background

(cherry picked from commit 6119fb0)

* Correct splitext() description, and example (#74377)

`splitext()` returns a 2-tuple of strings, and the last element of the return value includes the `.`

(cherry picked from commit c295de6)

* Using "~" instead of "+" for concatination (#74364)

Changed FAQ examples to conform with the Jinja documentation:
If both values on either side of a plus/+ are numbers, they will be added whereas using "~" will convert all operands into strings and then concatenate them. Closes #73799.

(cherry picked from commit e6a5245)

* Docs - Split Developing collections page, add info on optional module_utils (#74105)

*

(cherry picked from commit c90922e)

* Add weos4 network platform to documentation (#74088)

* Add weos4 network platform to documentation

* Fix small format issues

(cherry picked from commit 7ca5ded)

* Fix typo in Makefile (#74396)

Fixed minor typo specfic -> specific

(cherry picked from commit 4880fee)

* Update complex_data_manipulation.rst (#72509)

(cherry picked from commit c2985c4)

* Update VMware library installation docs (#71219)

Depending upon OS/distro, please use pip/pip3.

(cherry picked from commit ddfc648)

* Update AWS dev guides to use collections utils and fragments (#72312)

(cherry picked from commit cf08c23)

* Use is_boto3_error_code in 'standard' example (#72313)

Use is_boto3_error_code in 'standard' example rather than e.response['Error']['Code'] (#72313)

Co-authored-by: Sloane Hertel <shertel@redhat.com>
(cherry picked from commit 63afb33)

* Update Kubernetes collection name in docs (#74440)

(cherry picked from commit 8d499bb)

* Update argcomplete docs links on installation guide (#74410)

Link on installation docs is outdated. Switch to currently docs at: https://kislyuk.github.io/argcomplete/

(cherry picked from commit f97787c)

* fix spacing to fix header, reorg contributing page (#74421)

Co-authored-by: John R Barker <john@johnrbarker.com>
(cherry picked from commit 9d9b08b)

* Update first_found documentation (#70502)

* import_tasks do not work with loop, use use include_tasks instead
* update documentation

(cherry picked from commit bacede7)

* Product-related updates. (#74454)

(cherry picked from commit 34c9ed8)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Co-authored-by: Sandra McCann <samccann@redhat.com>
Co-authored-by: Alex Willmer <alex@moreati.org.uk>
Co-authored-by: Hublerho <43293510+Hublerho@users.noreply.github.com>
Co-authored-by: Ernst Oudhof <17832702+ernst-s@users.noreply.github.com>
Co-authored-by: Hu Shuai <hus.fnst@cn.fujitsu.com>
Co-authored-by: dhx-mike-palandra <45608336+dhx-mike-palandra@users.noreply.github.com>
Co-authored-by: jakelevinez <31458570+jakelevinez@users.noreply.github.com>
Co-authored-by: Mark Chappell <mchappel@redhat.com>
Co-authored-by: Lidiane Taquehara <lidi.mayra@gmail.com>
Co-authored-by: Alex Domoradov <alex.hha@gmail.com>
Co-authored-by: Bill Nottingham <notting@redhat.com>
@ansible ansible locked and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.12 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. new_contributor This PR is the first contribution by a new community member. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants