functional backport of 74448 #74567
Merged
functional backport of 74448 #74567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acozine
added
backport
samccann
approved these changes
May 4, 2021
ansibot
added
core_review
bcoca
reviewed
May 4, 2021
| @@ -278,7 +278,7 @@ | |||
| # choice but to create world readable temporary files to execute a module on | |||
| # the remote machine. This option is False by default for security. Users may | |||
| # turn this on to have behaviour more like Ansible prior to 2.1.x. See | |||
| # https://docs.ansible.com/ansible/latest/user_guide/become.html#becoming-an-unprivileged-user | |||
| # https://docs.ansible.com/ansible/latest/user_guide/become.html#risks-of-becoming-an-unprivileged-user | |||
There was a problem hiding this comment.
'latest' will eventually be wrong, it should keep either within it's version (2.11) or be relative (why it should use doclink)
There was a problem hiding this comment.
As long as we leave it hard-coded to /ansible/latest, I think this is the best we can do. There are no docs at the URL /ansible/2.11/. At any rate, I didn't change that part in this PR - if we want to fix it to use relative links we can do that in another PR. Meanwhile at least this will take users to a relevant section of the docs.
There was a problem hiding this comment.
Also, the advice on handling the risks of becoming an unprivileged user have not changed, nor are they likely to.
sivel
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#74448 won't backport cleanly because we are not backporting #74324.
Instead of wrestling with the merge conflict and trying to get this into a Docs Backportapalooza, we opened this PR as a functional backport of commit c63b867.
ISSUE TYPE
COMPONENT NAME
docs.ansible.com