Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.10] Remove incidental Azure tests #74681

Merged
merged 3 commits into from May 12, 2021
Merged

[stable-2.10] Remove incidental Azure tests #74681

merged 3 commits into from May 12, 2021

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented May 12, 2021 •
edited

SUMMARY

Backport of #71037 and #71164 for Ansible 2.10. #71052 was already backported to stable-2.10 in #72159.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

.azure-pipelines/azure-pipelines.yml
test/integration/targets/incidental_azure_rm_resource
test/sanity/ignore.txt
test/support/integration/plugins/module_utils/azure_rm_common.py
test/support/integration/plugins/module_utils/azure_rm_common_rest.py
test/support/integration/plugins/modules/_azure_rm_mariadbconfiguration_facts.py
test/support/integration/plugins/modules/_azure_rm_mariadbdatabase_facts.py
test/support/integration/plugins/modules/_azure_rm_mariadbfirewallrule_facts.py
test/support/integration/plugins/modules/_azure_rm_mariadbserver_facts.py
test/support/integration/plugins/modules/_azure_rm_resource_facts.py
test/support/integration/plugins/modules/_azure_rm_webapp_facts.py
test/support/integration/plugins/modules/azure_rm_appserviceplan.py
test/support/integration/plugins/modules/azure_rm_functionapp.py
test/support/integration/plugins/modules/azure_rm_functionapp_info.py
test/support/integration/plugins/modules/azure_rm_mariadbconfiguration.py
test/support/integration/plugins/modules/azure_rm_mariadbconfiguration_info.py
test/support/integration/plugins/modules/azure_rm_mariadbdatabase.py
test/support/integration/plugins/modules/azure_rm_mariadbdatabase_info.py
test/support/integration/plugins/modules/azure_rm_mariadbfirewallrule.py
test/support/integration/plugins/modules/azure_rm_mariadbfirewallrule_info.py
test/support/integration/plugins/modules/azure_rm_mariadbserver_info.py
test/support/integration/plugins/modules/azure_rm_resource.py
test/support/integration/plugins/modules/azure_rm_resource_info.py
test/support/integration/plugins/modules/azure_rm_storageaccount.py
test/support/integration/plugins/modules/azure_rm_webapp.py
test/support/integration/plugins/modules/azure_rm_webapp_info.py
test/support/integration/plugins/modules/azure_rm_webappslot.py
test/utils/shippable/incidental/azure.sh

ADDITIONAL INFORMATION

I verified that no aliases files are referencing any Azure tests.

relrod and others added 3 commits May 12, 2021 16:03
@relrod @samdoran
Remove incidental_azure_rm_mariadbserver tests (ansible#71037)
eb9b7d0 
Change:
- Remove incidental test which has no remaining incidental coverage.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 96aa81e)
@samdoran
Remove incidental azure tests (ansible#71164)
972680c 
Change:
- All incidental coverage from these tests has moved to intentional
  coverage.

Test Plan:
- CI

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit 4f54fb8)
@samdoran
Remove incidental Azure tests from matrix
f5e3c04
@samdoran samdoran requested a review from mattclay May 12, 2021 20:37
@ansibot
Copy link
Contributor

ansibot commented May 12, 2021

@samdoran The following file(s) in this pull request are bundled copies of modules used to support incidental tests and should not be updated:

  • test/support/integration/plugins/module_utils/azure_rm_common.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/module_utils/azure_rm_common_rest.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/_azure_rm_mariadbconfiguration_facts.py
    • Possible match in the following collections: community.azure
  • test/support/integration/plugins/modules/_azure_rm_mariadbdatabase_facts.py
    • Possible match in the following collections: community.azure
  • test/support/integration/plugins/modules/_azure_rm_mariadbfirewallrule_facts.py
    • Possible match in the following collections: community.azure
  • test/support/integration/plugins/modules/_azure_rm_mariadbserver_facts.py
    • Possible match in the following collections: community.azure
  • test/support/integration/plugins/modules/_azure_rm_resource_facts.py
    • Possible match in the following collections: community.azure
  • test/support/integration/plugins/modules/_azure_rm_webapp_facts.py
    • Possible match in the following collections: community.azure
  • test/support/integration/plugins/modules/azure_rm_appserviceplan.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_functionapp.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_functionapp_info.py
    • Possible match in the following collections: azure.azcollection, community.azure, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_mariadbconfiguration.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_mariadbconfiguration_info.py
    • Possible match in the following collections: azure.azcollection, community.azure, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_mariadbdatabase.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_mariadbdatabase_info.py
    • Possible match in the following collections: azure.azcollection, community.azure, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_mariadbfirewallrule.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_mariadbfirewallrule_info.py
    • Possible match in the following collections: azure.azcollection, community.azure, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_mariadbserver.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_mariadbserver_info.py
    • Possible match in the following collections: azure.azcollection, community.azure, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_resource.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_resource_info.py
    • Possible match in the following collections: azure.azcollection, community.azure, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_storageaccount.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_webapp.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_webapp_info.py
    • Possible match in the following collections: azure.azcollection, community.azure, paultaiton.azcollection
  • test/support/integration/plugins/modules/azure_rm_webappslot.py
    • Possible match in the following collections: azure.azcollection, paultaiton.azcollection

Because the original module(s) have been migrated to collections, please re-submit this pull request in relevant collection repositories, typically under https://github.com/ansible-collections.

If you need further assistence with identifying the correct repository, please stop by IRC or the mailing list:

click here for bot help

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. collection Related to Ansible Collections work collection:ktdreyer.errata_tool_ansible core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 12, 2021
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label May 12, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 12, 2021
@mattclay mattclay merged commit d1978c6 into ansible:stable-2.10 May 12, 2021
@samdoran samdoran deleted the backport-remove-azure-incidental-tests branch May 12, 2021 21:41
@ansible ansible locked and limited conversation to collaborators Jun 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. collection:ktdreyer.errata_tool_ansible collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. small_patch support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdoran @ansibot @mattclay @relrod