Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't mutate os.environ in AnsibleModule.run_command, make a copy, and pass to Popen #74791

Merged
merged 8 commits into from May 25, 2021
Merged

Don't mutate os.environ in AnsibleModule.run_command, make a copy, and pass to Popen #74791

merged 8 commits into from May 25, 2021

Conversation

sivel
Copy link
Member

@sivel sivel commented May 21, 2021 •
edited

SUMMARY

Don't mutate os.environ in AnsibleModule.run_command, make a copy, and pass to Popen. Fixes #74783

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/basic.py

ADDITIONAL INFORMATION

This PR has been extended to address a few other thread safety issues, specifically with os.chdir and os.umask

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.12 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 21, 2021
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label May 21, 2021
@sivel sivel mentioned this pull request May 21, 2021
Merged
@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label May 21, 2021
@sivel sivel marked this pull request as ready for review May 21, 2021 19:59
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels May 21, 2021
samdoran
samdoran reviewed May 25, 2021
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs a changelog.

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label May 25, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels May 25, 2021
@samdoran samdoran merged commit 9813858 into ansible:devel May 25, 2021
@ansible ansible locked and limited conversation to collaborators Jun 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran left review comments

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
4 participants
@sivel @bcoca @samdoran @ansibot