-
Notifications
You must be signed in to change notification settings - Fork 23.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump antsibull version from 0.40.1 to 0.41.0 and ansible sphinx theme version to fix HTML generation in return value tables #76759
Conversation
…n return value tables.
The Sphinx theme also generates invalid HTML; will be fixed by ansible-community/sphinx_ansible_theme#44. |
Ok, the generated HTML should be correct (or at least have a lot less errors than before). But now that we waited so long, we can also wait another week until ansible-community/community-topics#61 is resolved, and include a new antsibull release. That one will also support the new I think it's worth the wait. @samccann what do you think? |
Yes let's wait before bumping the antsibull version. That way I can test both changes locally before we merge this PR. |
ready_for_review |
…ning (-- inside comment). (For those interested in the history of this: http://www.howtocreate.co.uk/SGMLComments.html#doubledash)
@felixfontein thanks! |
@samccann thanks for testing, reviewing and merging :) |
… version to fix HTML generation in return value tables (ansible#76759) * Use Jinja2 comment instead of HTML comment to avoid W3C validator warning (-- inside comment). (For those interested in the history of this: http://www.howtocreate.co.uk/SGMLComments.html#doubledash)
SUMMARY
Follow-up PR to #76675. Most important change in antsibull 0.40.2 is ansible-community/antsibull#387 which fixes broken HTML in return value tables. While most browsers simply ignored it and rendered the result fine, lynx wouldn't render the result.
ISSUE TYPE
COMPONENT NAME
docs build