Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate core vs collection contributor guides #76764

Merged
merged 6 commits into from
Jan 21, 2022

Conversation

samccann
Copy link
Contributor

SUMMARY

This is a first pass attempt to separate core vs collection contributor guidelines whilst also creating a general community guide for all.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/ansible_index.rst

ADDITIONAL INFORMATION

@samccann samccann marked this pull request as draft January 14, 2022 21:00
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.13 docs This issue/PR relates to or includes documentation. docs_only All changes are to files within the docs/docsite/ directory docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 14, 2022
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jan 18, 2022
@samccann
Copy link
Contributor Author

samccann commented Jan 18, 2022

This is how it looks now for Ansible (pkg) -
image
And for ansible-core:
image

@sivel
Copy link
Member

sivel commented Jan 18, 2022

Just wanted to call out that we've been getting a number of reports that documentation is hard to find when looking for anything ansible-core specific, like roadmaps for example. Historically because we have only had /ansible/ for docs, that is where most people still go, and cannot find some of the docs they are searching for.

I feel it probably makes most sense to have ansible-core as the base, and layer on the community stuff. Otherwise, people will likely only ever rind the contributing docs for ansible-core if someone from core actually hands them the link.

@samccann
Copy link
Contributor Author

Historically, we had two separate sites because core release didn't coincide with Ansible package release. Now that they are more closely aligned, we could reconsider that strategy. The drawback of one site is that we couldn't say update ansible-2.13 to latest until Ansible 6 releases about a month later.

Meanwhile, I can put the core roadmap on the Ansible (/ansible/) docsite as well. And I'll adjust this PR to put the contributing to core guide on the Ansible site as well. (AKA default to a complete set of docs on /ansible/ and a core only set of docs on /ansible-core/ for now.

* Ansibot reviews the PR
* Ansibot assigns labels
* Ansibot pings maintainers
* Azure Pipelines runs the test suite

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth covering other CI tools used ? Like for some collections where Zuul is used and has some unique labels / comments for triggering retries like the "recheck" comment cmd etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in another PR, sure. At this point, i'm just moving the files around so we have separate guides. Then I'll being the Great Edit of it all :-)

@samccann samccann marked this pull request as ready for review January 19, 2022 17:44
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jan 19, 2022
@samccann
Copy link
Contributor Author

Copy link
Contributor

@ariordan-redhat ariordan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw one typo; otherwise, LGTM.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 20, 2022
Co-authored-by: Aine Riordan <44700011+ariordan-redhat@users.noreply.github.com>
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Automated PR review: ansibullbot
--------------------------------

Because Ansible receives many pull requests, and because we love automating things, we have automated several steps of the process of reviewing and merging pull requests with a tool called Ansibullbot, or Ansibot for short.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only applies to ansible/ansible and very few collection repos. Might be worth mentioning that when this is updated later. (For now - the split up - we can keep it as-is.)

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 21, 2022
@ariordan-redhat ariordan-redhat merged commit cfe4bdc into ansible:devel Jan 21, 2022
@samccann
Copy link
Contributor Author

Picked up the other comments here in this quick PR for now so I don't forget entirely - #76817 and thanks!

@samccann samccann deleted the community-hack branch January 21, 2022 20:20
briantist pushed a commit to briantist/ansible that referenced this pull request Feb 1, 2022
* updated core guides
* ansible package docs guides
* add core guide to Ansible docs
* Update docs/docsite/rst/community/maintainers.rst
konstruktoid pushed a commit to konstruktoid/ansible-upstream that referenced this pull request Feb 2, 2022
* updated core guides
* ansible package docs guides
* add core guide to Ansible docs
* Update docs/docsite/rst/community/maintainers.rst
@ansible ansible locked and limited conversation to collaborators Feb 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.13 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. has_issue support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants