Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add links.yml to collection structure docs #77415

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

samccann
Copy link
Contributor

SUMMARY

Describe what this file does and point to the template file for complete details.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/dev_guide/developing_collections_structure.rst

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Mar 30, 2022

Thanks for your Ansible docs contribution! We talk about Ansible documentation on maxtrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs! We meet there on Tuesdays (see the Ansible calendar) and welcome additions to our weekly agenda items - scroll down to find the upcoming agenda and add a comment to put something new on that agenda.

click here for bot help

@ansibot ansibot added affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docs_only All changes are to files within the docs/docsite/ directory docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 30, 2022
@ansibot
Copy link
Contributor

ansibot commented Mar 30, 2022

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/dev_guide/developing_collections_structure.rst:75:0: warning: Unknown target name: "collection_template links.yml <https://github.com/ansible-collections/collection_template/blob/main/docs/docsite/links.yml".

The test ansible-test sanity --test rstcheck [explain] failed with 1 error:

docs/docsite/rst/dev_guide/developing_collections_structure.rst:75:0: Unknown target name: "collection_template links.yml <https://github.com/ansible-collections/collection_template/blob/main/docs/docsite/links.yml".

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 30, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 30, 2022
Co-authored-by: Felix Fontein <felix@fontein.de>
Copy link
Contributor

@ariordan-redhat ariordan-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made one suggestion, but LGTM.

Co-authored-by: Aine Riordan <44700011+ariordan-redhat@users.noreply.github.com>
@ariordan-redhat ariordan-redhat merged commit 8caa6ef into ansible:devel Mar 30, 2022
@felixfontein
Copy link
Contributor

@samccann @ariordan-redhat thanks!

@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Mar 31, 2022
samccann added a commit to samccann/ansible that referenced this pull request Mar 31, 2022
* add links.yml to collection structure docs
* fix link
* Update docs/docsite/rst/dev_guide/developing_collections_structure.rst

(cherry picked from commit 8caa6ef)
@samccann samccann deleted the collection-links branch April 4, 2022 18:08
sivel pushed a commit that referenced this pull request Apr 5, 2022
* add links.yml to collection structure docs (#77415)

* add links.yml to collection structure docs
* fix link
* Update docs/docsite/rst/dev_guide/developing_collections_structure.rst

(cherry picked from commit 8caa6ef)

* Example is a single play, not a playbook

(cherry picked from commit bf8e186)

* Fix list formatting (#77354)

(cherry picked from commit e918cfa)

* Most Matrix channels are ansible.com and not .im (#77352)

(cherry picked from commit 6557a60)

* Docs cheatsheet - skeleton and ansible-playbook (#76655)

(cherry picked from commit 21addac)

Co-authored-by: rwhector <richard@walnut.gen.nz>
Co-authored-by: Christian Adamini <christian.adamini@invision.de>
Co-authored-by: bluikko <14869000+bluikko@users.noreply.github.com>
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
@ansible ansible locked and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants