Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to install optional packages in DNF package groups #77492

Closed
wants to merge 4 commits into from
Closed

Add an option to install optional packages in DNF package groups #77492

wants to merge 4 commits into from

Conversation

s-hertel
Copy link
Contributor

@s-hertel s-hertel commented Apr 7, 2022

SUMMARY

Fixes #67187

Since this is a DNF-specific option (like allowerasing and nobest), this is only available for dnf tasks.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

dnf

@ansibot ansibot added affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 7, 2022
@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Apr 7, 2022
mkrizek
mkrizek reviewed Apr 8, 2022
View reviewed changes
lib/ansible/modules/dnf.py Outdated Show resolved Hide resolved
mkrizek
mkrizek reviewed Apr 8, 2022
View reviewed changes
lib/ansible/modules/dnf.py Outdated Show resolved Hide resolved
mkrizek
mkrizek approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@mkrizek mkrizek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor question otherwise LGTM.

@s-hertel
Copy link
Contributor Author

s-hertel commented Apr 8, 2022

Maybe this can also be added to the yum module with --setopt. with-optional/--with-optional isn't a group install option before yum2dnf is available, but yum --setopt=group_package_types=mandatory,default,optional group install works.

@mkrizek
Copy link
Contributor

mkrizek commented Apr 12, 2022

Maybe this can also be added to the yum module with --setopt. with-optional/--with-optional isn't a group install option before yum2dnf is available, but yum --setopt=group_package_types=mandatory,default,optional group install works.

Nice find. I am +1 for adding that.

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 12, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed shipit This PR is ready to be merged by Core labels Apr 13, 2022
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Apr 21, 2022
@s-hertel s-hertel marked this pull request as draft August 17, 2022 15:57
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Aug 17, 2022
@ansibot ansibot added stale_review Updates were made after the last review and the last review is more than 7 days old. has_issue labels Jul 12, 2023
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Sep 15, 2023
@webknjaz

This comment was marked as resolved.

Sign in to view
@azure-pipelines

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 18, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Oct 2, 2023
@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label Oct 16, 2023
@s-hertel s-hertel closed this Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.14 feature This issue/PR relates to a feature request. has_issue module This issue/PR relates to a module. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yum module cannot use group install --with-optional
5 participants
@s-hertel @mkrizek @webknjaz @ansibot @nitzmahone