Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated subclassing DefaultCallback without doc_fragment #77677

Merged
merged 3 commits into from
Apr 29, 2022
Merged

Remove deprecated subclassing DefaultCallback without doc_fragment #77677

merged 3 commits into from
Apr 29, 2022

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Apr 28, 2022

SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

lib/ansible/plugins/callback/default.py

@ansibot ansibot added affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 28, 2022
@ansibot

This comment was marked as resolved.

Sign in to view
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. test This PR relates to tests. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 28, 2022
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Apr 28, 2022
@mattclay
Copy link
Member

Looks good, but needs conflicts resolved.

@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 28, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 29, 2022
@mkrizek mkrizek merged commit dbdbfe8 into ansible:devel Apr 29, 2022
@mkrizek mkrizek deleted the remove-default-doc branch April 29, 2022 07:32
@ansible ansible locked and limited conversation to collaborators May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.14 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkrizek @ansibot @mattclay