pip module - editable now applies to all packages #78039
+14
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
WIP
ansibot
added
core_review
bcoca
added
P3
ansibot
added
the
stale_ci
When editable is set to true, -e flag should be passed to all packages. This change passes -e flag before each package name. However, if a requirements file is used, then editable flag raises errors. Therefore, editable and requirements are now mutually exclusive. Fixes ansible#77755 Signed-off-by: Nirmal Patel <nirmal@nirmal.dev>
nirmal-j-patel
force-pushed
the
pip_editable_fix
branch
from
da338a1
to
bb12409
Compare
ansibot
removed
the
stale_ci
ansibot
added
the
stale_ci
Akasurde
requested changes
Sep 1, 2023
Comment on lines
+2
to
+4
| - pip - when editable set to true, '-e' flag is passed before each package. | ||
| When requirments file is used, editable flag does not pass '-e' to avoid | ||
| errors. |
There was a problem hiding this comment.
Suggested change
| - pip - when editable set to true, '-e' flag is passed before each package. | |
| When requirments file is used, editable flag does not pass '-e' to avoid | |
| errors. | |
| - pip - when editable is set to true, '-e' flag is passed before each package. | |
| When the requirements file is used, the editable flag does not pass '-e' to avoid | |
| errors. |
| mutually_exclusive=[ | ||
| ['name', 'requirements'], | ||
| ['executable', 'virtualenv'], | ||
| ['editable', 'requirements'], |
There was a problem hiding this comment.
Add a documentation note about this change.
| if extra_args: | ||
| cmd.extend(shlex.split(extra_args)) | ||
|
|
||
| if name: | ||
| cmd.extend(to_native(p) for p in packages) | ||
| for p in packages: |
There was a problem hiding this comment.
Please create a changelog fragment. See this fragment as an example. Also, add tests for this change.
ansibot
added
the
needs_revision
ansibot
added
the
needs_ci
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
removed
needs_ci
|
This branch needs a rebase. |
|
Apologies for the delay. I'm the next few days, I will rebase this branch and add a test case. I believe I don't need to add a new change log fragment because I already added one. Please correct me if I am wrong. |
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When editable is set to true, -e flag should be passed to all packages. This change passes -e flag before each package name. However, if a requirements file is used, then editable flag raises errors. Therefore, editable and requirements are now mutually exclusive.
Fixes #77755
ISSUE TYPE
ADDITIONAL INFORMATION
While fixing the bug, I noticed that
-eflag was being passed when using requirements file with editable options on. This results in an error. To avoid having this error,requirementsandeditableare now mutually exclusive.This is the error: