Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ctypes to access shadow, instead of spwd which is deprecated #78050

Merged
merged 6 commits into from
Jun 16, 2022
Merged

Use ctypes to access shadow, instead of spwd which is deprecated #78050

merged 6 commits into from
Jun 16, 2022

Conversation

sivel
Copy link
Member

@sivel sivel commented Jun 13, 2022

SUMMARY

Use ctypes to access shadow, instead of spwd which is deprecated

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/user.py

ADDITIONAL INFORMATION

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.14 bug This issue/PR relates to a bug. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 13, 2022
@ansibot

This comment was marked as outdated.

Sign in to view
@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Jun 13, 2022
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 14, 2022
@ansibot ansibot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. labels Jun 14, 2022
@sivel
Copy link
Member Author

sivel commented Jun 14, 2022

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jun 14, 2022
@sivel sivel marked this pull request as ready for review June 14, 2022 21:21
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Jun 14, 2022
@sivel sivel requested review from mattclay and bcoca June 15, 2022 21:12
@sivel sivel merged commit a90f666 into ansible:devel Jun 16, 2022
@ansible ansible locked and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sivel @ansibot @mattclay @bcoca