Fix AIX processor facts and add unit test #78223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.14
bug
|
The test The test |
ansibot
added
needs_revision
zorun
changed the title
ansibot
added
core_review
|
I did some archeology, and it turns out that this code has been here forever, with only minor changes since 2013: 6a89177 introduced in Ansible 1.1. Maybe processors had just one core at the time, which may explain why they confused the total number of threads and the number of threads per core. |
|
@zorun It is very difficult to get an AIX system for testing, maybe that is the reason this part of the code is untouched. |
|
@Akasurde this is why I added unit tests from the two AIX machines I have access on https://cfarm.tetaneutral.net/machines/list/ |
mkrizek
removed
the
needs_triage
|
Please create a changelog fragment. |
|
Done! |
- `processor_count` was erroneously set to the number of cores
- `processor_cores` was erroneously set to the number of threads per core
- `processor_vcpus` and `processor_threads_per_core` were not set
- `processor` was a string, while it's supposed to be a list
Before:
```
"ansible_processor": "PowerPC_POWER7",
"ansible_processor_cores": 4,
"ansible_processor_count": 12,
```
After:
```
"ansible_processor": [
"PowerPC_POWER7"
],
"ansible_processor_cores": 12,
"ansible_processor_count": 1,
"ansible_processor_threads_per_core": 4,
"ansible_processor_vcpus": 48,
```
Also add a unit test.
ansibot
added
needs_revision
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
processor_countwas erroneously set to the number of coresprocessor_coreswas erroneously set to the number of threads per coreprocessor_vcpusandprocessor_threads_per_corewere not setprocessorwas a string, while it's supposed to be a listISSUE TYPE
COMPONENT NAME
facts/hardware/aix
ADDITIONAL INFORMATION
Before:
After: