Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KeyError for ansible-galaxy when caching paginated responses from v3 #78325

Merged
merged 3 commits into from Jul 21, 2022

Conversation

s-hertel
Copy link
Contributor

SUMMARY

Fixes #77911, thanks to @sivel for the patch here #77911 (comment). Added a test to confirm the fix.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-galaxy

@ansibot ansibot added affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 21, 2022
@mattclay mattclay requested a review from jborean93 July 21, 2022 19:09
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Jul 21, 2022
@jborean93
Copy link
Contributor

Changes look good, have manually tested against the latest Galaxy NG using the community.vmware collection mentioned in the original issue and things work. Thanks @s-hertel for fixing this.

@jborean93 jborean93 merged commit 5728d72 into ansible:devel Jul 21, 2022
@ansible ansible locked and limited conversation to collaborators Jul 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ansible-galaxy fails to install collection from GalaxyNG when there are many versions
5 participants