Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow handlers from dynamic includes to be notified #78399

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Do not allow handlers from dynamic includes to be notified #78399

merged 3 commits into from
Aug 2, 2022

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Aug 1, 2022

SUMMARY

ci_complete

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/plugins/strategy/__init__.py

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.14 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 1, 2022
@mkrizek mkrizek marked this pull request as ready for review August 2, 2022 11:41
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. small_patch labels Aug 2, 2022
@bcoca
Copy link
Member

bcoca commented Aug 2, 2022

can haz test?

@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Aug 2, 2022
@bcoca bcoca merged commit ce6c9be into ansible:devel Aug 2, 2022
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Aug 2, 2022
@mkrizek mkrizek deleted the dont-expose-included-handlers branch August 2, 2022 15:22
@ansible ansible locked and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

Assignees
No one assigned
Labels
affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkrizek @bcoca @sivel @ansibot