Refactored test_equals_none() function #78585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.14
bug
Well, they may produce side effects. Have you checked that? What does the original commit say? |
|
Or maybe those lines are missing the |
webknjaz
reviewed
Aug 19, 2022
| @@ -69,10 +69,6 @@ def test_get_groups(self): | |||
|
|
|||
| def test_equals_none(self): | |||
| other = None | |||
| self.hostA == other | |||
There was a problem hiding this comment.
@alikins can you recall what these were for?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@mattclay I'm puzzled why this is happening under Python 3.9-3.11: 00:53 ==================================== ERRORS ====================================
00:53 ______________ ERROR collecting test/units/inventory/test_host.py ______________
00:53 ImportError while importing test module '/root/ansible/test/units/inventory/test_host.py'.
00:53 Hint: make sure your test modules/packages have valid Python names.
00:53 Traceback:
00:53 /usr/lib/python3.10/importlib/__init__.py:126: in import_module
00:53 return _bootstrap._gcd_import(name[level:], package, level)
00:53 test/units/inventory/test_host.py:25: in <module>
00:53 from units.compat import unittest
00:53 E ModuleNotFoundError: No module named 'units'I've restarted the jobs but the change doesn't seem to be caused by this patch 🤔. |
ansibot
added
core_review
Hi @webknjaz, as you probably saw the original commit #17827 for this test did not provide a reason for these equality statements, so I'm confused why these are here and causing the failed checks. I appreciate you looking into this issue. |
ansibot
added
needs_revision
I'm actually not sure your changes are causing this. Which is why I tagged @mattclay, so we could get to the bottom of this in case it's If the changes were to cause this, my best guess is side effects caused by the dunder methods at https://github.com/ansible/ansible/blob/045f303/lib/ansible/inventory/host.py#L43. Although, I don't see anything that could actually cause a side effect there. |
|
@mattclay noticed that missing |
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Aug 19, 2022
Sometimes pytest errors out with an `ImportError` during its tests collection stage when a Python package/directory containing the test module does not have an `__init__.py` in it. This is being observed under Python 3.9 and higher. The patch provides a workaround for this problem but does not address the root cause which is currently unknown. Ref: ansible#78585 (comment)
|
This will fix it #78592 |
webknjaz
added a commit
that referenced
this pull request
Aug 19, 2022
Sometimes pytest errors out with an `ImportError` during its tests collection stage when a Python package/directory containing the test module does not have an `__init__.py` in it. This is being observed under Python 3.9 and higher. The patch provides a workaround for this problem but does not address the root cause which is currently unknown. Ref: #78585 (comment)
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Aug 19, 2022
Sometimes pytest errors out with an `ImportError` during its tests collection stage when a Python package/directory containing the test module does not have an `__init__.py` in it. This is being observed under Python 3.9 and higher. The patch provides a workaround for this problem but does not address the root cause which is currently unknown. Ref: ansible#78585 (comment) (cherry picked from commit beb70da)
ansibot
added
core_review
|
@alexwholland it's green now, but I'd still go for adding |
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Aug 19, 2022
Sometimes pytest errors out with an `ImportError` during its tests collection stage when a Python package/directory containing the test module does not have an `__init__.py` in it. This is being observed under Python 3.9 and higher. The patch provides a workaround for this problem but does not address the root cause which is currently unknown. Ref: ansible#78585 (comment) (cherry picked from commit beb70da)
webknjaz
added a commit
to webknjaz/ansible
that referenced
this pull request
Aug 19, 2022
Sometimes pytest errors out with an `ImportError` during its tests collection stage when a Python package/directory containing the test module does not have an `__init__.py` in it. This is being observed under Python 3.9 and higher. The patch provides a workaround for this problem but does not address the root cause which is currently unknown. Ref: ansible#78585 (comment) (cherry picked from commit beb70da)
mattclay
approved these changes
Aug 19, 2022
ansibot
added
needs_revision
webknjaz
added
the
ci_verified
webknjaz
reviewed
Aug 22, 2022
webknjaz
reviewed
Aug 22, 2022
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
ansibot
added
core_review
s-hertel
removed
the
needs_triage
sivel
pushed a commit
that referenced
this pull request
Aug 30, 2022
Sometimes pytest errors out with an `ImportError` during its tests collection stage when a Python package/directory containing the test module does not have an `__init__.py` in it. This is being observed under Python 3.9 and higher. The patch provides a workaround for this problem but does not address the root cause which is currently unknown. Ref: #78585 (comment) (cherry picked from commit beb70da)
ansibot
added
the
stale_ci
nitzmahone
pushed a commit
that referenced
this pull request
Aug 31, 2022
Sometimes pytest errors out with an `ImportError` during its tests collection stage when a Python package/directory containing the test module does not have an `__init__.py` in it. This is being observed under Python 3.9 and higher. The patch provides a workaround for this problem but does not address the root cause which is currently unknown. Ref: #78585 (comment) (cherry picked from commit beb70da)
nitzmahone
pushed a commit
that referenced
this pull request
Aug 31, 2022
Sometimes pytest errors out with an `ImportError` during its tests collection stage when a Python package/directory containing the test module does not have an `__init__.py` in it. This is being observed under Python 3.9 and higher. The patch provides a workaround for this problem but does not address the root cause which is currently unknown. Ref: #78585 (comment) (cherry picked from commit beb70da)
ansibot
added
needs_rebase
|
@alexwholland Thanks for submitting this PR. It looks like we forgot about this after the most recent changes were made. These fixes, along with other similar fixes, were merged as part of: #79940 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Removed equality statements in the
test_equals_none()function since they are never used.ISSUE TYPE
COMPONENT NAME
test/units/inventory/test_host.py