Ssh keygen trials #78655
Closed
Ssh keygen trials #78655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.14
core_review
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
ci_verified
ansibot
added
core_review
bcoca
reviewed
Aug 29, 2022
ansibot
added
needs_revision
bcoca
reviewed
Aug 29, 2022
ansibot
added
core_review
|
you still need a changelog and it would be a good idea to add tests |
bcoca
approved these changes
Aug 30, 2022
mkrizek
removed
the
needs_triage
mkrizek
reviewed
Aug 30, 2022
mkrizek
reviewed
Aug 30, 2022
bcoca
reviewed
Aug 31, 2022
lib/ansible/modules/user.py
Outdated
| @@ -3078,7 +3095,8 @@ def main(): | |||
| bits=0, | |||
| type='rsa', | |||
| passphrase=None, | |||
| comment='ansible-generated on %s' % socket.gethostname() | |||
| comment='ansible-generated on %s' % socket.gethostname(), | |||
| trials=100 | |||
There was a problem hiding this comment.
if we are changing the name to rounds, i would try to keep it consistent everywhere, it can be very confusing to the next person that has to debug that trials == rounds
ansibot
added
the
stale_ci
|
Great idea. I would have needed the feature before. How do you proceed with the PR now? Is there anything missing in the implementation? @bcoca @mkrizek @crasyhorse |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Suggest to Add ssh-keygen -a (Trials) Option. Fixes #78473
ISSUE TYPE
COMPONENT NAME
user