Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error for context-dependent redirects #78755

Merged
merged 1 commit into from
Sep 13, 2022
Merged

Error for context-dependent redirects #78755

merged 1 commit into from
Sep 13, 2022

Conversation

s-hertel
Copy link
Contributor

SUMMARY

Error for non-fqcn collection redirects since they shouldn't be context-dependent.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugin/loader.py

@ansibot ansibot added affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Sep 12, 2022
@s-hertel s-hertel mentioned this pull request Sep 12, 2022
Merged
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Sep 12, 2022
@sivel
Copy link
Member

sivel commented Sep 12, 2022 •
edited

Here are the collections in ansible 6.3.0 that will be affected by this change:

  • theforeman.foreman
  • check_point.mgmt
non-fqcn redirs from ansible 6.3.0... 

{
    "check_point/mgmt/meta/runtime.yml": {
        "hi": "hello"
    },
    "theforeman/foreman/meta/runtime.yml": {
        "foreman_architecture": "architecture",
        "foreman_auth_source_ldap": "auth_source_ldap",
        "foreman_bookmark": "bookmark",
        "foreman_compute_attribute": "compute_attribute",
        "foreman_compute_profile": "compute_profile",
        "foreman_compute_resource": "compute_resource",
        "foreman_config_group": "config_group",
        "foreman_domain": "domain",
        "foreman_environment": "puppet_environment",
        "foreman_external_usergroup": "external_usergroup",
        "foreman_global_parameter": "global_parameter",
        "foreman_host": "host",
        "foreman_host_power": "host_power",
        "foreman_hostgroup": "hostgroup",
        "foreman_image": "image",
        "foreman_installation_medium": "installation_medium",
        "foreman_job_template": "job_template",
        "foreman_location": "location",
        "foreman_model": "hardware_model",
        "foreman_operatingsystem": "operatingsystem",
        "foreman_organization": "organization",
        "foreman_os_default_template": "os_default_template",
        "foreman_provisioning_template": "provisioning_template",
        "foreman_ptable": "partition_table",
        "foreman_realm": "realm",
        "foreman_role": "role",
        "foreman_scap_content": "scap_content",
        "foreman_scap_tailoring_file": "scap_tailoring_file",
        "foreman_scc_account": "scc_account",
        "foreman_scc_product": "scc_product",
        "foreman_search_facts": "resource_info",
        "foreman_setting": "setting",
        "foreman_smart_class_parameter": "smart_class_parameter",
        "foreman_snapshot": "snapshot",
        "foreman_subnet": "subnet",
        "foreman_templates_import": "templates_import",
        "foreman_user": "user",
        "foreman_usergroup": "usergroup",
        "katello_activation_key": "activation_key",
        "katello_content_credential": "content_credential",
        "katello_content_view": "content_view",
        "katello_content_view_filter": "content_view_filter",
        "katello_content_view_version": "content_view_version",
        "katello_host_collection": "host_collection",
        "katello_lifecycle_environment": "lifecycle_environment",
        "katello_manifest": "subscription_manifest",
        "katello_product": "product",
        "katello_repository": "repository",
        "katello_repository_set": "repository_set",
        "katello_sync": "repository_sync",
        "katello_sync_plan": "sync_plan",
        "katello_upload": "content_upload"
    }
}

non-fqcn redirs from latest versions of all collections from community galaxy... 

{
    "beeankha/awx/meta/runtime.yml": {
        "tower_notification": "tower_notification_template"
    },
    "check_point/mgmt/meta/runtime.yml": {
        "hi": "hello"
    },
    "codeaffen/foreman/meta/runtime.yml": {
        "foreman_architecture": "architecture",
        "foreman_auth_source_ldap": "auth_source_ldap",
        "foreman_bookmark": "bookmark",
        "foreman_compute_attribute": "compute_attribute",
        "foreman_compute_profile": "compute_profile",
        "foreman_compute_resource": "compute_resource",
        "foreman_config_group": "config_group",
        "foreman_domain": "domain",
        "foreman_environment": "puppet_environment",
        "foreman_external_usergroup": "external_usergroup",
        "foreman_global_parameter": "global_parameter",
        "foreman_host": "host",
        "foreman_host_power": "host_power",
        "foreman_hostgroup": "hostgroup",
        "foreman_image": "image",
        "foreman_installation_medium": "installation_medium",
        "foreman_job_template": "job_template",
        "foreman_location": "location",
        "foreman_model": "hardware_model",
        "foreman_operatingsystem": "operatingsystem",
        "foreman_organization": "organization",
        "foreman_os_default_template": "os_default_template",
        "foreman_provisioning_template": "provisioning_template",
        "foreman_ptable": "partition_table",
        "foreman_realm": "realm",
        "foreman_role": "role",
        "foreman_scap_content": "scap_content",
        "foreman_scap_tailoring_file": "scap_tailoring_file",
        "foreman_scc_account": "scc_account",
        "foreman_scc_product": "scc_product",
        "foreman_search_facts": "resource_info",
        "foreman_setting": "setting",
        "foreman_smart_class_parameter": "smart_class_parameter",
        "foreman_snapshot": "snapshot",
        "foreman_subnet": "subnet",
        "foreman_templates_import": "templates_import",
        "foreman_user": "user",
        "foreman_usergroup": "usergroup",
        "katello_activation_key": "activation_key",
        "katello_content_credential": "content_credential",
        "katello_content_view": "content_view",
        "katello_content_view_filter": "content_view_filter",
        "katello_content_view_version": "content_view_version",
        "katello_host_collection": "host_collection",
        "katello_lifecycle_environment": "lifecycle_environment",
        "katello_manifest": "subscription_manifest",
        "katello_product": "product",
        "katello_repository": "repository",
        "katello_repository_set": "repository_set",
        "katello_sync": "repository_sync",
        "katello_sync_plan": "sync_plan",
        "katello_upload": "content_upload"
    },
    "dellemc/powermax/meta/runtime.yml": {
        "dellemc_powermax_gatherfacts": "info",
        "dellemc_powermax_host": "host",
        "dellemc_powermax_hostgroup": "hostgroup",
        "dellemc_powermax_initiator": "initiator",
        "dellemc_powermax_job": "job",
        "dellemc_powermax_maskingview": "maskingview",
        "dellemc_powermax_metrodr": "metrodr",
        "dellemc_powermax_port": "port",
        "dellemc_powermax_portgroup": "portgroup",
        "dellemc_powermax_rdfgroup": "rdfgroup",
        "dellemc_powermax_snapshot": "snapshot",
        "dellemc_powermax_snapshotpolicy": "snapshotpolicy",
        "dellemc_powermax_srdf": "srdf",
        "dellemc_powermax_storagegroup": "storagegroup",
        "dellemc_powermax_storagepool": "storagepool",
        "dellemc_powermax_volume": "volume"
    },
    "dellemc/powerscale/meta/runtime.yml": {
        "dellemc_powerscale_accesszone": "accesszone",
        "dellemc_powerscale_ads": "ads",
        "dellemc_powerscale_filesystem": "filesystem",
        "dellemc_powerscale_gatherfacts": "info",
        "dellemc_powerscale_group": "group",
        "dellemc_powerscale_groupnet": "groupnet",
        "dellemc_powerscale_ldap": "ldap",
        "dellemc_powerscale_networkpool": "networkpool",
        "dellemc_powerscale_networkrule": "networkrule",
        "dellemc_powerscale_networksettings": "networksettings",
        "dellemc_powerscale_nfs": "nfs",
        "dellemc_powerscale_node": "node",
        "dellemc_powerscale_settings": "settings",
        "dellemc_powerscale_smartquota": "smartquota",
        "dellemc_powerscale_smb": "smb",
        "dellemc_powerscale_snapshot": "snapshot",
        "dellemc_powerscale_snapshotschedule": "snapshotschedule",
        "dellemc_powerscale_subnet": "subnet",
        "dellemc_powerscale_synciqjob": "synciqjob",
        "dellemc_powerscale_synciqpolicy": "synciqpolicy",
        "dellemc_powerscale_synciqreports": "synciqreports",
        "dellemc_powerscale_synciqrules": "synciqrules",
        "dellemc_powerscale_synciqtargetreports": "synciqtargetreports",
        "dellemc_powerscale_user": "user"
    },
    "dellemc/unity/meta/runtime.yml": {
        "dellemc_unity_consistencygroup": "consistencygroup",
        "dellemc_unity_filesystem": "filesystem",
        "dellemc_unity_filesystem_snapshot": "filesystem_snapshot",
        "dellemc_unity_gatherfacts": "info",
        "dellemc_unity_host": "host",
        "dellemc_unity_info": "info",
        "dellemc_unity_nasserver": "nasserver",
        "dellemc_unity_nfs": "nfs",
        "dellemc_unity_smbshare": "smbshare",
        "dellemc_unity_snapshot": "snapshot",
        "dellemc_unity_snapshotschedule": "snapshotschedule",
        "dellemc_unity_storagepool": "storagepool",
        "dellemc_unity_tree_quota": "tree_quota",
        "dellemc_unity_user_quota": "user_quota",
        "dellemc_unity_volume": "volume"
    },
    "evgeni/foreman/meta/runtime.yml": {
        "foreman_architecture": "architecture",
        "foreman_auth_source_ldap": "auth_source_ldap",
        "foreman_bookmark": "bookmark",
        "foreman_compute_attribute": "compute_attribute",
        "foreman_compute_profile": "compute_profile",
        "foreman_compute_resource": "compute_resource",
        "foreman_config_group": "config_group",
        "foreman_domain": "domain",
        "foreman_environment": "puppet_environment",
        "foreman_external_usergroup": "external_usergroup",
        "foreman_global_parameter": "global_parameter",
        "foreman_host": "host",
        "foreman_host_power": "host_power",
        "foreman_hostgroup": "hostgroup",
        "foreman_image": "image",
        "foreman_installation_medium": "installation_medium",
        "foreman_job_template": "job_template",
        "foreman_location": "location",
        "foreman_model": "hardware_model",
        "foreman_operatingsystem": "operatingsystem",
        "foreman_organization": "organization",
        "foreman_os_default_template": "os_default_template",
        "foreman_provisioning_template": "provisioning_template",
        "foreman_ptable": "partition_table",
        "foreman_realm": "realm",
        "foreman_role": "role",
        "foreman_scap_content": "scap_content",
        "foreman_scap_tailoring_file": "scap_tailoring_file",
        "foreman_scc_account": "scc_account",
        "foreman_scc_product": "scc_product",
        "foreman_search_facts": "resource_info",
        "foreman_setting": "setting",
        "foreman_smart_class_parameter": "smart_class_parameter",
        "foreman_snapshot": "snapshot",
        "foreman_subnet": "subnet",
        "foreman_templates_import": "templates_import",
        "foreman_user": "user",
        "foreman_usergroup": "usergroup",
        "katello_activation_key": "activation_key",
        "katello_content_credential": "content_credential",
        "katello_content_view": "content_view",
        "katello_content_view_filter": "content_view_filter",
        "katello_content_view_version": "content_view_version",
        "katello_host_collection": "host_collection",
        "katello_lifecycle_environment": "lifecycle_environment",
        "katello_manifest": "subscription_manifest",
        "katello_product": "product",
        "katello_repository": "repository",
        "katello_repository_set": "repository_set",
        "katello_sync": "repository_sync",
        "katello_sync_plan": "sync_plan",
        "katello_upload": "content_upload"
    },
    "theforeman/foreman/meta/runtime.yml": {
        "foreman_architecture": "architecture",
        "foreman_auth_source_ldap": "auth_source_ldap",
        "foreman_bookmark": "bookmark",
        "foreman_compute_attribute": "compute_attribute",
        "foreman_compute_profile": "compute_profile",
        "foreman_compute_resource": "compute_resource",
        "foreman_config_group": "config_group",
        "foreman_domain": "domain",
        "foreman_environment": "puppet_environment",
        "foreman_external_usergroup": "external_usergroup",
        "foreman_global_parameter": "global_parameter",
        "foreman_host": "host",
        "foreman_host_power": "host_power",
        "foreman_hostgroup": "hostgroup",
        "foreman_image": "image",
        "foreman_installation_medium": "installation_medium",
        "foreman_job_template": "job_template",
        "foreman_location": "location",
        "foreman_model": "hardware_model",
        "foreman_operatingsystem": "operatingsystem",
        "foreman_organization": "organization",
        "foreman_os_default_template": "os_default_template",
        "foreman_provisioning_template": "provisioning_template",
        "foreman_ptable": "partition_table",
        "foreman_realm": "realm",
        "foreman_role": "role",
        "foreman_scap_content": "scap_content",
        "foreman_scap_tailoring_file": "scap_tailoring_file",
        "foreman_scc_account": "scc_account",
        "foreman_scc_product": "scc_product",
        "foreman_search_facts": "resource_info",
        "foreman_setting": "setting",
        "foreman_smart_class_parameter": "smart_class_parameter",
        "foreman_snapshot": "snapshot",
        "foreman_subnet": "subnet",
        "foreman_templates_import": "templates_import",
        "foreman_user": "user",
        "foreman_usergroup": "usergroup",
        "katello_activation_key": "activation_key",
        "katello_content_credential": "content_credential",
        "katello_content_view": "content_view",
        "katello_content_view_filter": "content_view_filter",
        "katello_content_view_version": "content_view_version",
        "katello_host_collection": "host_collection",
        "katello_lifecycle_environment": "lifecycle_environment",
        "katello_manifest": "subscription_manifest",
        "katello_product": "product",
        "katello_repository": "repository",
        "katello_repository_set": "repository_set",
        "katello_sync": "repository_sync",
        "katello_sync_plan": "sync_plan",
        "katello_upload": "content_upload"
    }
}

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Sep 12, 2022
@felixfontein felixfontein mentioned this pull request Sep 13, 2022
Closed
This was referenced Sep 13, 2022
Closed
Closed
Closed
Closed
@felixfontein
Copy link
Contributor

I created an issue in theforeman.foreman for that: theforeman/foreman-ansible-modules#1484

check_point.mgmt is interesting since in the collection's repo, the meta/runtime.yml file does not have any redirect: https://github.com/CheckPointSW/CheckPointAnsibleMgmtCollection/blob/master/meta/runtime.yml I downloaded the galaxy tarball, and that one does contain the redirect, and a different requires_ansible value as well. I've created CheckPointSW/CheckPointAnsibleMgmtCollection#84 for that.

From the remaining collections, beeankha.awx, codeaffen.foreman, and evgeni.foreman seem to be dead tests (last published years ago), but dellemc.powermax, dellemc.powerscale, dellemc.unity seem to be active. While I was at it, I also created issues for these.

@evgeni
Copy link
Contributor

evgeni commented Sep 13, 2022

Indeed, codeaffen.foreman and evgeni.foreman are playgrounds and can be safely ignored.

I've opened a PR against theforeman.foreman to fix this.

@sivel sivel merged commit 563f3ec into ansible:devel Sep 13, 2022
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Sep 13, 2022
@felixfontein felixfontein mentioned this pull request Sep 18, 2022
Merged
@ansible ansible locked and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

@bcoca bcoca bcoca approved these changes

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

Assignees
No one assigned
Labels
affects_2.14 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@s-hertel @sivel @felixfontein @evgeni @bcoca @mkrizek @ansibot