added number of matches to replace parameter #79094
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shivam Durgbuns <shivamdurgbuns@gmail.com>
ansibot
added
affects_2.15
feature
This comment was marked as outdated.
This comment was marked as outdated.
ansibot
added
ci_verified
Signed-off-by: Shivam Durgbuns <shivamdurgbuns@gmail.com>
ansibot
removed
ci_verified
bcoca
requested changes
Oct 11, 2022
ansibot
added
the
needs_revision
Sure will do that @bcoca |
s-hertel
removed
the
needs_triage
anirbandey303
approved these changes
Oct 15, 2022
ansibot
added
the
stale_ci
zedr
reviewed
Nov 25, 2022
| @@ -0,0 +1,2 @@ | |||
| minor_changes: | |||
| - added new `numberofmatches` paramter to replace function to replace the first n number of occurances (https://github.com/ansible/ansible/issues/78866) | |||
zedr
reviewed
Nov 25, 2022
| after: "<Location /2>" | ||
| regexp: 'Require\s+[^\n]+$' | ||
| replace: 'Require ip {{ ips | join(" ") }}' | ||
| numberofmatches: 1 |
There was a problem hiding this comment.
Consider using count to reflect the actual keyword parameter that you are using.
|
@shivamdurgbuns consider adding these tests:
|
|
Closing for inactivity |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shivam Durgbuns shivamdurgbuns@gmail.com
SUMMARY
Added
numberofmatchesparameter to replace functionality to replace the first n number of matches during a replace function, the default is set to 0 i.e all the occurrences will be replaced.Fixes: #78866
ISSUE TYPE
COMPONENT NAME
replace