Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible-test - Fix pylint error with old home dir #80151

Merged
merged 1 commit into from Mar 7, 2023
Merged

ansible-test - Fix pylint error with old home dir #80151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/ansible-test-pylint-home.yml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- ansible-test - Set ``PYLINTHOME`` for the ``pylint`` sanity test to prevent failures due to ``pylint`` checking for the existence of an obsolete home directory.
5 changes: 5 additions & 0 deletions test/lib/ansible_test/_internal/commands/sanity/pylint.py
View file
Open in desktop
Expand Up @@ -41,6 +41,7 @@
get_collection_detail,
CollectionDetail,
CollectionDetailError,
ResultType,
)

from ...config import (
Expand Down Expand Up @@ -248,6 +249,10 @@ def pylint(
# expose plugin paths for use in custom plugins
env.update(dict(('ANSIBLE_TEST_%s_PATH' % k.upper(), os.path.abspath(v) + os.path.sep) for k, v in data_context().content.plugin_paths.items()))

# Set PYLINTHOME to prevent pylint from checking for an obsolete directory, which can result in a test failure due to stderr output.
# See: https://github.com/PyCQA/pylint/blob/e6c6bf5dfd61511d64779f54264b27a368c43100/pylint/constants.py#L148
env.update(PYLINTHOME=os.path.join(ResultType.TMP.path, 'pylint'))

if paths:
display.info('Checking %d file(s) in context "%s" with config: %s' % (len(paths), context, rcfile), verbosity=1)

Expand Down