Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

psrp - fix up script chdir setting #81282

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

jborean93
Copy link
Contributor

SUMMARY

The psrp connection plugin runs commands in a unique way due to the nature of the underlying protocol it uses. When _low_level_execute_command is called with a custom chdir value it simply just prepends cd {path} ; {cmd}. This PR updates the login in psrp to take this into account and to try and set the value properly if it's running with the standard module payload command that script would use.

Fixes: #81277

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

psrp

@ansibot ansibot added needs_triage Needs a first human triage before being processed. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. has_issue and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Jul 17, 2023
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Jul 18, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 1, 2023
@ansibot ansibot added the bug This issue/PR relates to a bug. label Aug 8, 2023
@jborean93
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 22, 2023
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 5, 2023
@nitzmahone
Copy link
Member

Backlog bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug. has_issue stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

psrp plugin bug with script module using chdir argument
4 participants