Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pause cpu consumption #81519

Merged
merged 4 commits into from Aug 22, 2023
Merged

Fix pause cpu consumption #81519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e3bc9d3
Add a sleep when prompting to reduce CPU consumption
s-hertel Aug 15, 2023
5829817
add changelog
s-hertel Aug 15, 2023
0f639f1
Add code comment
s-hertel Aug 15, 2023
8f028ad
Fix hardcoded sleep interval to use the config option
s-hertel Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/fix-display-prompt-cpu-consumption.yml
View file
Open in desktop
@@ -0,0 +1,2 @@
bugfixes:
- Prompting - add a short sleep between polling for user input to reduce CPU consumption (https://github.com/ansible/ansible/issues/81516).
2 changes: 2 additions & 0 deletions lib/ansible/utils/display.py
View file
Open in desktop
Expand Up @@ -708,6 +708,8 @@ def _read_non_blocking_stdin(
os.set_blocking(self._stdin_fd, False)
while key_pressed is None and (seconds is None or (time.time() - start < seconds)):
key_pressed = self._stdin.read(1)
# throttle to prevent excess CPU consumption
time.sleep(C.DEFAULT_INTERNAL_POLL_INTERVAL)
finally:
os.set_blocking(self._stdin_fd, True)
if key_pressed is None:
Expand Down