New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix task.resolved_action callbacks #82003
base: devel
Are you sure you want to change the base?
Conversation
@nitzmahone Not sure if you have any thoughts on this, but after thinking about this in conjunction with module_defaults, I'm wondering if the For example, say vyos_mod1 and vyos_mod2 are redirected to the action plugin vyos. To prevent module_defaults for vyos_mod1 clobbering the default args for vyos_mod2 or vice versa, they can add the If these tasks run while using a callback that displays the |
7c470cc
to
161204a
Compare
module invocations, also update unit tests to use plugins which exist Or I could wrap the new validation in a try/except ImportError to support the previous behavior for missing plugins?
43ee751
to
3ae00d6
Compare
I didn't actually realize this also fixes #81905, but it does so I added tests and a changelog. |
SUMMARY
Noticed while looking at the related fix to not use this attribute for module_defaults in #81909.
Not sure if there is a better way to set this - it feels a bit redundant to load the plugin context additional times.
ISSUE TYPE