ansible-galaxy - fixup role install failure handling - #82052
Closed
s-hertel wants to merge 1 commit into
Closed
Conversation
ansibot
added
bug
mkrizek
removed
the
needs_triage
s-hertel
marked this pull request as ready for review
October 24, 2023 19:02
s-hertel
force-pushed
the
fix-role-install-misc-and-symlinks
branch
from
October 24, 2023 19:04
53ecfd5 to
9d54a6d
Compare
s-hertel
marked this pull request as draft
October 24, 2023 19:14
ansibot
added
the
needs_revision
Closed
1 task
s-hertel
force-pushed
the
fix-role-install-misc-and-symlinks
branch
2 times, most recently
from
October 25, 2023 15:55
f5bc6ad to
81d0a32
Compare
s-hertel
marked this pull request as ready for review
October 25, 2023 15:55
ansibot
removed
the
needs_revision
ansibot
added
the
stale_ci
|
@s-hertel and @nitzmahone, this PR promises to fix other galaxy roles as well - do you have an ETA when this will land? Thanks. |
s-hertel
commented
Nov 7, 2023
Comment on lines
+420
to
+423
| # Doesn't happen with our build process, but avoid extracting members that aren't adjacent to the role metadata | ||
| display.warning(f"Only extracting members in {n_archive_parent_dir}: ignoring {member.name}") | ||
| ignore_external.add(member) | ||
| continue |
Contributor
Author
There was a problem hiding this comment.
If a tarfile contains something like:
./role-data/
├── role-name
│ ├── meta/main.yml
│ └── tasks
└── hitchhiker
└── keep
we find the meta/main.yml in the role-name directory, but install all tarfile members (not just those adjacent to the meta directory). On devel this ends up installing an invalid role (and so it needs to be manually deleted to reinstall).
This could be an error instead, but I thought the warning was better at least than installing a broken role.
Contributor
Author
|
@HarryWeppner I don't have an ETA (it needs a review), but I decided to split the symlinks fix into a separate PR #82165 to make it safer to backport, since the other issues this is fixing are not new. |
s-hertel
changed the title
s-hertel
marked this pull request as draft
November 7, 2023 21:57
ansibot
added
needs_revision
webknjaz
reviewed
Nov 14, 2023
webknjaz
reviewed
Nov 14, 2023
Member
|
A rebase should fix the rpmfluff issue in CI. |
webknjaz
added
the
ci_verified
ansibot
added
the
needs_rebase
ansibot
added
the
stale_ci
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
the
stale_pr
Make install more strict about what is extracted from the tarfile: - fail on invalid content we previously skipped - give a warning for excluded tarfile content that previously would have been included
s-hertel
force-pushed
the
fix-role-install-misc-and-symlinks
branch
from
January 29, 2025 16:42
06fdc78 to
74ed460
Compare
ansibot
removed
needs_rebase
webknjaz
reviewed
Jan 30, 2025
| from ansible import context | ||
| from ansible.errors import AnsibleError, AnsibleParserError | ||
| from ansible.galaxy.api import GalaxyAPI | ||
| from ansible.galaxy.collection import _tempdir |
Member
There was a problem hiding this comment.
Should this be made a public API?
webknjaz
reviewed
Jan 30, 2025
| if not os.path.exists(self.path): | ||
| os.makedirs(self.path) | ||
|
|
||
| for path in os.listdir(temporary_dest): |
Member
There was a problem hiding this comment.
Wouldn't it be more atomic to move the entire directory rather than parts of it one by one?
Contributor
Author
There was a problem hiding this comment.
This really needs tests first, please disregard the draft.
Contributor
Author
There was a problem hiding this comment.
I was just rebasing PRs with the stale_pr label.
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Roles are now extracted to a tempdir to prevent partial installs.
Tarfile members outside of the role root are no longer installed (leading to broken roles).
This method is getting long, maybe it's time to refactor it.
ISSUE TYPE