Missing Exception Handling in SSH Plugin Fixed Error Verbosity Issue #82354
+13
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
|
The test The test |
ansibot
removed
the
ci_verified
ansibot
removed
the
needs_revision
Hacodex
changed the title
jborean93
removed
the
needs_triage
jborean93
requested changes
Dec 7, 2023
There was a problem hiding this comment.
Are you able to add a changelog fragement for this change at https://docs.ansible.com/ansible/latest/community/development_process.html#creating-a-changelog-fragment.
| error_code = return_tuple[0] | ||
| cmd_error = to_native(return_tuple[2]).rstrip() | ||
| error_messages = { | ||
| 1: "sshpass: Invalid command line argument. Command given ({})".format(cmd_error), |
There was a problem hiding this comment.
I would avoid embedding the stderr for this and the next one in case it contains sensitive information that should not be exposed in no_log.
ansibot
added
the
needs_revision
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #58133
SUMMARY
ISSUE TYPE
ADDITIONAL INFORMATION