Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional Unsafe fixes #82376

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Additional Unsafe fixes #82376

merged 3 commits into from
Dec 7, 2023

Conversation

sivel
Copy link
Member

@sivel sivel commented Dec 6, 2023 •
edited

SUMMARY

Additional Unsafe fixes

Fixes #82356 - pickling with protocol=0
Fixes #82375 - Fixes bytes iteration expectations

ISSUE TYPE
  • Bugfix Pull Request
ADDITIONAL INFORMATION

@ansibot ansibot added bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. backport This PR does not target the devel branch. labels Dec 6, 2023
@carlosmmatos carlosmmatos mentioned this pull request Dec 7, 2023
Closed
@webknjaz
Copy link
Member

webknjaz commented Dec 7, 2023

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bcoca bcoca mentioned this pull request Dec 7, 2023
Closed
1 task
@sivel sivel marked this pull request as ready for review December 7, 2023 20:33
nitzmahone
nitzmahone requested changes Dec 7, 2023
View reviewed changes
Copy link
Member

@nitzmahone nitzmahone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor nit, otherwise LGTM

lib/ansible/utils/unsafe_proxy.py Outdated Show resolved Hide resolved
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Dec 7, 2023
@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Dec 7, 2023
@ansibot ansibot removed the stale_review Updates were made after the last review and the last review is more than 7 days old. label Dec 7, 2023
@sivel sivel merged commit afe3fc1 into ansible:stable-2.16 Dec 7, 2023
78 checks passed
sivel added a commit to sivel/ansible that referenced this pull request Dec 7, 2023
@sivel
[stable-2.15] Additional Unsafe fixes (ansible#82376)
5b78c91 
* Allow older pickle protocols to pickle unsafe classes. Fixes ansible#82356

* Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes ansible#82375

* clog frag
(cherry picked from commit afe3fc1)

Co-authored-by: Matt Martz <matt@sivel.net>
sivel added a commit to sivel/ansible that referenced this pull request Dec 7, 2023
@sivel
[stable-2.14] Additional Unsafe fixes (ansible#82376)
25ab699 
* Allow older pickle protocols to pickle unsafe classes. Fixes ansible#82356

* Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes ansible#82375

* clog frag
(cherry picked from commit afe3fc1)

Co-authored-by: Matt Martz <matt@sivel.net>
@upekkha upekkha mentioned this pull request Dec 11, 2023
Closed
sivel added a commit to sivel/ansible that referenced this pull request Dec 11, 2023
@sivel
[stable-2.14] Additional Unsafe fixes (ansible#82376)
c6d08dd 
* Allow older pickle protocols to pickle unsafe classes. Fixes ansible#82356

* Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes ansible#82375

* clog frag
(cherry picked from commit afe3fc1)

Co-authored-by: Matt Martz <matt@sivel.net>
sivel added a commit to sivel/ansible that referenced this pull request Dec 11, 2023
@sivel
[stable-2.15] Additional Unsafe fixes (ansible#82376)
d67fab8 
* Allow older pickle protocols to pickle unsafe classes. Fixes ansible#82356

* Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes ansible#82375

* clog frag
(cherry picked from commit afe3fc1)

Co-authored-by: Matt Martz <matt@sivel.net>
sivel added a commit that referenced this pull request Dec 11, 2023
@sivel
[stable-2.14] Additional Unsafe fixes (#82376) (#82381)
49c05da 
* Allow older pickle protocols to pickle unsafe classes. Fixes #82356

* Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes #82375

* clog frag
(cherry picked from commit afe3fc1)
sivel added a commit that referenced this pull request Dec 11, 2023
@sivel
[stable-2.15] Additional Unsafe fixes (#82376) (#82380)
b19cfb1 
* Allow older pickle protocols to pickle unsafe classes. Fixes #82356

* Address issues when iterating or getting single index from AnsibleUnsafeBytes. Fixes #82375

* clog frag
(cherry picked from commit afe3fc1)
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 14, 2023
@ansible ansible locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
backport This PR does not target the devel branch. bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sivel @webknjaz @nitzmahone @ansibot