plugin loader - cache .py files in all() #82448
Draft
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ansibot
added
bug
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
this is based on ansible#32609 * avoid calling glob.glob() when looking for py files in variable folders for each host listed in the inventory. In addition, I added a global cache so all plugin loaders stay in sync (not sure if this is wanted), and reset the cache when new directories are added to the loader, like the other caches. ansible#79687 also identifies this as a hot code path. Co-authored-by: Sloane Hertel <19572925+s-hertel@users.noreply.github.com>
s-hertel
force-pushed
the
cache-pluginloader-all-globbing
branch
from
e901b5b
to
f2c5c78
Compare
ansibot
removed
needs_rebase
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
this is based on #32609
In addition, I added a global cache so all plugin loaders stay in sync (not sure if this is wanted), and reset the cache when new directories are added to the loader, like the other caches.
#79687 also identifies this as a hot code path.
On devel, the inventory script given in #32609 as
time ansible-inventory -i inv.py --list --output /dev/nulltakes ~10 seconds, and on this branch ~5 seconds.ISSUE TYPE