apt_key: Consider expired keys while performing operations #82517
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
bug
* Expired keys were ignored previously causing unwanted effects while performing present and absent operations Fixes: ansible#82497 Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
removed
the
needs_revision
bcoca
requested changes
Jan 11, 2024
| @@ -255,7 +255,7 @@ def parse_output_for_keys(output, short_format=False): | |||
| found = [] | |||
| lines = to_native(output).split('\n') | |||
| for line in lines: | |||
| if (line.startswith("pub") or line.startswith("sub")) and "expired" not in line: | |||
| if line.startswith(("pub", "sub")): | |||
There was a problem hiding this comment.
this is incorrect, we should still not accept expired keys, but we do need to warn that this is the case
ansibot
added
the
needs_revision
jborean93
removed
the
needs_triage
ansibot
added
the
stale_ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
while performing present and absent operations
Fixes: #82497
Signed-off-by: Abhijeet Kasurde akasurde@redhat.com
ISSUE TYPE