Commits on Jan 17, 2024

1. Fix url encoded credentials in netloc …

   Prior to this commit, it was impossible to use a module like dnf with a
   URL that contains a username with an @ such as an email address
   username, because:
   
     dnf:
       name: https://foo@example.com:bar@example.com/some.rpm
   
   Would cause netloc parsing to fail. However, the following:
   
     dnf:
       name: https://foo%40example.com:bar@example.com/some.rpm
   
   Would also fail because ansible would *not* URL-decode the credentials,
   causing the following to be base64 encoded in the Authorization header:
   
     Zm9vJTQwZXhhbXBsZS5jb206YmFyCg==
   
   Which decodes to:
   
     foo%40example.com:foo
   
   Which is *not* the authorized username, and as such, *won't* pass basic
   auth.
   
   With this commit, Ansible's url lib behaves like curl, chromium, wget,
   etc, and encodes the above to:
   
     Zm9vQGV4YW1wbGUuY29tOmJhcgo=
   
   Which decodes to:
   
     foo@example.com:bar
   
   Which will actually pass the HTTP Basic Auth, and is the same behaviour
   that you will find ie. with:
   
     curl -vvI https://foo%40bar:test@example.com 2>&1 |grep Auth | awk '{ print $4 }'

   

   jpic committed Jan 17, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 1e5a12f
   • Browse repository at this point

   Copy the full SHA

   1e5a12f View commit details

   Browse the repository at this point in the history