Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Easier package mgr overrides #82629

Merged
merged 24 commits into from Apr 2, 2024
Merged

Easier package mgr overrides #82629

merged 24 commits into from Apr 2, 2024

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jan 31, 2024

ISSUE TYPE
  • Feature Pull Request

@ansibot ansibot added feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. module This issue/PR relates to a module. labels Jan 31, 2024
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Jan 31, 2024
samccann
samccann reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a little 'just say no to Latin' nits :-)

lib/ansible/modules/package.py Outdated Show resolved Hide resolved
lib/ansible/modules/package.py Outdated Show resolved Hide resolved
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Jan 31, 2024
@maxamillion
Copy link
Contributor

Idle curiosity. With this change, is it possible for a playbook or role to use set_fact to override the pkg_mgr mid-flight during a playbook?

@sivel
Copy link
Member

sivel commented Jan 31, 2024

Idle curiosity. With this change, is it possible for a playbook or role to use set_fact to override the pkg_mgr mid-flight during a playbook?

Technically yes. But this introduces a never before utilized variable, meant to define a package manager override for a system. It could be abused, but should offer an easy way to override, or define for a host. Even by just dropping a file on the remote host, and not defining it within the playbook.

@maxamillion
Copy link
Contributor

@sivel +1 - thank you

@maxamillion maxamillion mentioned this pull request Jan 31, 2024
Open
@ansible ansible deleted a comment from ansibot Feb 1, 2024
@ansibot ansibot removed the ci_verified Changes made in this PR are causing tests to fail. label Feb 1, 2024
@webknjaz webknjaz added the ci_verified Changes made in this PR are causing tests to fail. label Feb 1, 2024
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 1, 2024
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Feb 15, 2024
@ansible ansible deleted a comment from ansibot Mar 18, 2024
@ansible ansible deleted a comment from ansibot Mar 18, 2024
@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 18, 2024
@ansible ansible deleted a comment from ansibot Mar 19, 2024
@ansible ansible deleted a comment from ansibot Mar 19, 2024
@ansible ansible deleted a comment from ansibot Mar 25, 2024
@ansibot ansibot removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. ci_verified Changes made in this PR are causing tests to fail. labels Mar 25, 2024
@bcoca bcoca marked this pull request as ready for review March 25, 2024 16:18
@sivel sivel requested a review from nitzmahone March 25, 2024 20:31
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 28, 2024
@ansible ansible deleted a comment from ansibot Mar 29, 2024
@ansible ansible deleted a comment from ansibot Mar 29, 2024
@ansible ansible deleted a comment from ansibot Mar 29, 2024
@bcoca
Copy link
Member Author

bcoca commented Mar 29, 2024

One of the requirements was being able to set this on the EE, which they normally do by env vars, if they have to shift to alter inventory it won't work 'seamless' to the users as they upgrade the EE.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 1, 2024
@bcoca bcoca marked this pull request as ready for review April 2, 2024 16:10
sivel
sivel requested changes Apr 2, 2024
View reviewed changes
lib/ansible/plugins/action/package.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed stale_review Updates were made after the last review and the last review is more than 7 days old. labels Apr 2, 2024
@ansibot ansibot added the stale_review Updates were made after the last review and the last review is more than 7 days old. label Apr 2, 2024
@ansibot ansibot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Apr 2, 2024
@mattclay mattclay changed the title Eaiser package mgr overrides Easier package mgr overrides Apr 2, 2024
@bcoca bcoca merged commit 4bc6ffb into ansible:devel Apr 2, 2024
67 checks passed
@bcoca bcoca deleted the peek_pkg branch April 3, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz left review comments

@samccann samccann samccann left review comments

@sivel sivel sivel approved these changes

@nitzmahone nitzmahone nitzmahone approved these changes

Assignees
No one assigned
Labels
feature This issue/PR relates to a feature request. module This issue/PR relates to a module. stale_review Updates were made after the last review and the last review is more than 7 days old.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bcoca @maxamillion @sivel @webknjaz @nitzmahone @samccann @ansibot